Merge pull request #90 from vauxoo-dev/master-oca-fix-compute-none-moy

[FIX] method-NAME: Fix case compute=None
OCA · Dec 8, 2016 · 127f0cb · 127f0cb
2 parents 57fa5a7 + 6c21cfb
commit 127f0cb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/pylint_odoo/checkers/no_modules.py b/pylint_odoo/checkers/no_modules.py
@@ -318,7 +318,8 @@ def visit_call(self, node):
                     argument_aux = argument.value
                     if argument.arg in ['compute', 'search', 'inverse'] and \
                             isinstance(argument.value, astroid.Const) and \
-                            not argument.value.value.startswith(
+                            argument_aux.value and \
+                            not argument_aux.value.startswith(
                                 '_' + argument.arg + '_'):
                         self.add_message('method-' + argument.arg,
                                          node=argument_aux)

diff --git a/pylint_odoo/test_repo/broken_module/models/broken_model.py b/pylint_odoo/test_repo/broken_module/models/broken_model.py
@@ -39,6 +39,7 @@ class TestModel(models.Model):
         search='my_method_search',  # bad search method name
         inverse='my_method_inverse',  # bad inverse method name
     )
+    compute_none = fields.Char(compute=None)
 
     other_field2 = fields.char(
         'Other Field2',