[REF] checks_odoo_module_xml: Allow duplicated fields with 'groups'

Related to odoo/odoo#103743 Fix OCA/odoo-pre-commit-hooks#10
OCA · Oct 24, 2022 · 1695e57 · 1695e57
1 parent 12374c1
commit 1695e57
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/pylint_odoo/checkers/modules_odoo.py b/pylint_odoo/checkers/modules_odoo.py
@@ -777,6 +777,7 @@ def _get_duplicate_xml_fields(self, fields):
             all_fields.setdefault(
                 (field_xml, field.attrib.get('context'),
                  field.attrib.get('filter_domain'),
+                 field.attrib.get('groups'),
                  field.getparent()), []).append(field)
         # Remove all keys which not duplicated by excluding them from the
         return dict(((name, context, filter_domain, parent_node), nodes) for

diff --git a/pylint_odoo/test_repo/broken_module/model_view_odoo2.xml b/pylint_odoo/test_repo/broken_module/model_view_odoo2.xml
@@ -131,6 +131,9 @@
                         <tree>
                             <field name="name"/>
                             <field name="name"/>
+
+                            <field name="company_id" invisible="1"/>
+                            <field name="company_id" groups="base.group_multi_company"/>
                         </tree>
                     </field>
                     <field name="value_ids">