[ADD] eval-referenced: Detects if a "eval" is referenced (without cal…

…l it)

pylint_odoo/checkers/no_modules.py

@@ -186,6 +186,11 @@
         'old-api7-method-defined',
         settings.DESC_DFLT
     ),
+    'W%d11' % settings.BASE_NOMODULE_ID: (
+        '"eval" referenced detected.',
+        'eval-referenced',
+        settings.DESC_DFLT
+    ),
 }
 
 DFTL_MANIFEST_REQUIRED_KEYS = ['license']
@@ -483,6 +488,16 @@ def visit_assign(self, node):
                 self.add_message('attribute-deprecated',
                                  node=node_left, args=(node_left.name,))
 
+    @utils.check_messages('eval-referenced')
+    def visit_name(self, node):
+        """Detect when a "bad" built-in is referenced."""
+        node_infer = utils.safe_infer(node)
+        if not utils.is_builtin_object(node_infer):
+            # Skip not builtin objects
+            return
+        if node_infer.name == 'eval':
+            self.add_message('eval-referenced', node=node)
+
     def camelize(self, string):
         return re.sub(r"(?:^|_)(.)", lambda m: m.group(1).upper(), string)
 

pylint_odoo/test/main.py

@@ -53,6 +53,7 @@
     'translation-required': 4,
     'use-vim-comment': 1,
     'wrong-tabs-instead-of-spaces': 2,
+    'eval-referenced': 5,
     'xml-syntax-error': 2,
 }
 

pylint_odoo/test_repo/no_odoo_module/__init__.py

@@ -1,2 +1,3 @@
 # -*- coding: utf-8 -*-
 from . import myfile
+from . import eval_used

pylint_odoo/test_repo/no_odoo_module/eval_used.py

@@ -0,0 +1,20 @@
+# -*- coding: utf-8 -*-
+
+
+def func2(param):
+    """eval used from param"""
+    param("c = 2")
+
+
+def func3():
+    """eval used from many ways"""
+    my_dict = {
+        'my_eval': eval,  # [eval-used]
+    }
+    my_list = [eval]  # [eval-used]
+
+    my_var = eval  # [eval-used]
+    # inferred case
+    my_var('d = 3')  # [eval-used]
+    func2(eval)  # [eval-used]
+    return my_dict, my_list