Merge 0bf1861 into 4960c52

OCA · Oct 20, 2022 · c433fb1 · c433fb1
2 parents 4960c52 + 0bf1861
commit c433fb1
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 2 deletions.
diff --git a/pylint_odoo/checkers/no_modules.py b/pylint_odoo/checkers/no_modules.py
@@ -55,6 +55,7 @@
 import itertools
 import os
 import re
+from collections import Counter
 
 import astroid
 import rfc3986
@@ -258,6 +259,11 @@
         'context-overridden',
         settings.DESC_DFLT
     ),
+    'W%d25' % settings.BASE_NOMODULE_ID: (
+        'The file "%s" is duplicated %d times from manifest key "%s"',
+        'manifest-data-duplicated',
+        settings.DESC_DFLT
+    ),
     'F%d01' % settings.BASE_NOMODULE_ID: (
         'File "%s": "%s" not found.',
         'resource-not-exist',
@@ -822,7 +828,7 @@ def visit_call(self, node):
         'manifest-required-author', 'manifest-required-key',
         'manifest-version-format', 'resource-not-exist',
         'website-manifest-key-not-valid-uri', 'development-status-allowed',
-        'manifest-maintainers-list')
+        'manifest-maintainers-list', 'manifest-data-duplicated')
     def visit_dict(self, node):
         if not os.path.basename(self.linter.current_file) in \
                 settings.MANIFEST_FILES \
@@ -881,9 +887,13 @@ def visit_dict(self, node):
                                    self.config.manifest_version_format_parsed))
 
         # Check if resource exist
+        # Check manifest-data-duplicated
         dirname = os.path.dirname(self.linter.current_file)
         for key in DFTL_MANIFEST_DATA_KEYS:
-            for resource in (manifest_dict.get(key) or []):
+            for resource, coincidences in Counter(manifest_dict.get(key) or []):
+                if coincidences >= 2:
+                    self.add_message('manifest-data-duplicated', node=node,
+                                     args=(resource, coincidences, key))
                 if os.path.isfile(os.path.join(dirname, resource)):
                     continue
                 self.add_message('resource-not-exist', node=node,

diff --git a/pylint_odoo/test/main.py b/pylint_odoo/test/main.py
@@ -37,6 +37,7 @@
     'javascript-lint': 24,
     'license-allowed': 1,
     'manifest-author-string': 1,
+    'manifest-data-duplicated': 1,
     'manifest-deprecated-key': 1,
     'manifest-required-author': 1,
     'manifest-required-key': 1,

diff --git a/pylint_odoo/test_repo/broken_module/__openerp__.py b/pylint_odoo/test_repo/broken_module/__openerp__.py
@@ -15,6 +15,8 @@
         'skip_xml_check.xml',
         'skip_xml_check_2.xml',
         'skip_xml_check_3.xml',
+        'duplicated.xml',
+        'duplicated.xml',
         'report.xml',
         'template1.xml',
     ],