Merge 0a18c9b into d260411

pylint_odoo/checkers/no_modules.py

@@ -144,6 +144,12 @@
         'str-format-used',
         settings.DESC_DFLT
     ),
+    'E%d06' % settings.BASE_NOMODULE_ID: (
+        'Use of `requests.%s` method without timeout. '
+        'It could wait for a long time',
+        'request-without-timeout',
+        settings.DESC_DFLT
+    ),
     'C%d01' % settings.BASE_NOMODULE_ID: (
         'One of the following authors must be present in manifest: %s',
         'manifest-required-author',
@@ -589,11 +595,13 @@ def visit_print(self, node):
                           'translation-contains-variable',
                           'print-used', 'translation-positional-used',
                           'str-format-used', 'context-overridden',
+                          'request-without-timeout',
                           )
     def visit_call(self, node):
         infer_node = utils.safe_infer(node.func)
         if utils.is_builtin_object(infer_node) and infer_node.name == 'print':
             self.add_message('print-used', node=node)
+        # TODO: Add self.linter.is_message_enabled() for each section
         if ('fields' == self.get_func_lib(node.func) and
                 isinstance(node.parent, astroid.Assign) and
                 isinstance(node.parent.parent, astroid.ClassDef)):
@@ -750,6 +758,20 @@ def visit_call(self, node):
         if self._check_sql_injection_risky(node):
             self.add_message('sql-injection', node=node)
 
+        # requests calls
+        func_name = self.get_func_name(node.func)
+        if func_name in ('get', 'post'):
+            if self.get_func_lib(node.func) == 'requests':
+                # TODO: Get imported node renamed
+                for argument in misc.join_node_args_kwargs(node):
+                    if not isinstance(argument, astroid.Keyword):
+                        continue
+                    if argument.arg == 'timeout':
+                        break
+                else:
+                    self.add_message(
+                        'request-without-timeout', node=node, args=(func_name,))
+
     @utils.check_messages(
         'license-allowed', 'manifest-author-string', 'manifest-deprecated-key',
         'manifest-required-author', 'manifest-required-key',

pylint_odoo/test/main.py

@@ -56,6 +56,8 @@
     'po-msgstr-variables': 6,
     'print-used': 1,
     'redundant-modulename-xml': 1,
+    # TODO: update after fixing other TODO :)
+    'request-without-timeout': 2,
     'rst-syntax-error': 2,
     'sql-injection': 21,
     'str-format-used': 3,

pylint_odoo/test_repo/broken_module/models/broken_model.py

@@ -3,6 +3,9 @@
 import psycopg2
 from psycopg2 import sql
 from psycopg2.sql import SQL, Identifier
+import requests
+from requests import post, get
+from requests import post as post_r, get as get_r
 
 from openerp import fields, models, _
 from openerp.exceptions import Warning as UserError
@@ -16,6 +19,7 @@
 
 
 other_field = fields.Char()
+import requests
 
 
 def function_no_method():
@@ -537,6 +541,22 @@ def func(self, a):
         length = len(a)
         return length
 
+    def requests_test(self):
+        # request without timeout
+        requests.post('http://localhost')
+        requests.get('http://localhost')
+        post('http://localhost')
+        get('http://localhost')
+        post_r('http://localhost')
+        get_r('http://localhost')
+
+        # Valid cases
+        requests.post('http://localhost', timeout=10)
+        requests.get('http://localhost', timeout=10)
+        post('http://localhost', timeout=10)
+        get('http://localhost', timeout=10)
+        post_r('http://localhost', timeout=10)
+        get_r('http://localhost', timeout=10)
 
 class NoOdoo(object):
     length = 0