[ADD] except-pass: Emit message If a except:pass is used (OCA/#252)

pylint_odoo/checkers/modules_odoo.py

@@ -117,6 +117,12 @@
         'missing-manifest-dependency',
         settings.DESC_DFLT
     ),
+    'W%d38' % settings.BASE_OMODULE_ID: (
+        'pass into block except. '
+        'If you really need to use the pass consider logging that exception',
+        'except-pass',
+        settings.DESC_DFLT
+    ),
     'W%d37' % settings.BASE_OMODULE_ID: (
         '%s The xml attribute is missing the translation="off" tag %s',
         'xml-attribute-translatable',
@@ -351,6 +357,15 @@ def visit_import(self, node):
             if isinstance(node.scope(), astroid.Module):
                 self._check_imported_packages(node, name)
 
+    @utils.check_messages('except-pass')
+    def visit_tryexcept(self, node):
+        """Visit block try except"""
+        for handler in node.handlers:
+            if (not handler.name and
+                    len(handler.body) == 1 and
+                    isinstance(handler.body[0], astroid.node_classes.Pass)):
+                self.add_message('except-pass', node=handler)
+
     def _check_rst_syntax_error(self):
         """Check if rst file there is syntax error
         :return: False if exists errors and

pylint_odoo/test/main.py

@@ -58,6 +58,7 @@
     'wrong-tabs-instead-of-spaces': 2,
     'eval-referenced': 5,
     'xml-syntax-error': 2,
+    'except-pass': 3,
     'attribute-string-redundant': 33,
     'renamed-field-parameter': 2,
     'xml-attribute-translatable': 1,

pylint_odoo/test_repo/test_module/except_pass.py

@@ -0,0 +1,61 @@
+# -*- coding: utf-8 -*-
+"""Test Except Pass usage"""
+
+
+class TestExceptPass(object):
+    """Test Except Pass class """
+
+    def test_method(self):
+        try:
+            raise Exception('Exception')
+        except Exception:  # except-pass
+            pass
+
+    def test_2_method(self):
+        """This pass is skip for body of except has more than one line """
+        try:
+            raise Exception('Exception')
+        except Exception:
+            pass
+            print('Exception')
+
+    def test_3_method(self):
+        """This pass is skip for the exception is assigned"""
+        try:
+            raise Exception('Exception')
+        except Exception as exception:
+            pass
+        if exception:
+            pass
+
+    def test_4_method(self):
+        try:
+            raise Exception('Exception')
+        except Exception, userError:
+            pass
+        if userError:
+            pass
+
+    def test_5_method(self):
+        try:
+            raise Exception('Exception')
+        except (Exception, IndexError) as exception:
+            pass
+        if exception:
+            pass
+
+    def test_6_method(self):
+        try:
+            raise Exception('Exception')
+        except (Exception, IndexError):  # except-pass
+            pass
+
+    def test_7_method(self):
+        try:
+            raise Exception('Exception')
+        except (Exception, IndexError, NameError), exception:
+            pass
+        except Exception:  # except-pass
+            pass
+        if exception:
+            pass