[FIX] manifest-version-format: Adds matching for string end to default manifest version format #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t manifest version format Issue OCA#152
moylop260
reviewed
Sep 5, 2017
| @@ -234,7 +234,7 @@ | |||
| DFTL_VALID_ODOO_VERSIONS = [ | |||
| '4.2', '5.0', '6.0', '6.1', '7.0', '8.0', '9.0', '10.0' | |||
| ] | |||
| DFTL_MANIFEST_VERSION_FORMAT = r"(%(valid_odoo_versions)s)\.\d+\.\d+\.\d+" | |||
| DFTL_MANIFEST_VERSION_FORMAT = r"(%(valid_odoo_versions)s)\.\d+\.\d+\.\d+$" | |||
There was a problem hiding this comment.
Add ^ to "starts with" too
There was a problem hiding this comment.
re.match(), which is used in formatversion() to check the version number checks from beginning of the string, so the ^ would be redundant.
There was a problem hiding this comment.
Oh yeah!
You are right! (again!) 😄
moylop260
requested changes
Sep 5, 2017
naglis
changed the title
…e end of module version
moylop260
approved these changes
Sep 5, 2017
moylop260
added a commit
to vauxoo-dev/maintainer-quality-tools
that referenced
this pull request
Sep 18, 2017
After merge OCA/pylint-odoo#155 we had this unexpected wrong format version
moylop260
pushed a commit
to OCA/maintainer-quality-tools
that referenced
this pull request
Sep 19, 2017
…ver the weblate-ssh server (#484) * [FIX] apis.py: Adding new metod _ssh_keyscan to run the ssh-keyscan over the weblate-ssh server (#233) * [REF] broken_deprecated: Use correct version format - After merge OCA/pylint-odoo#155 we had this unexpected wrong format version
bt-admin
pushed a commit
to brain-tec/maintainer-quality-tools
that referenced
this pull request
Oct 20, 2017
…ver the weblate-ssh server (OCA#484) * [FIX] apis.py: Adding new metod _ssh_keyscan to run the ssh-keyscan over the weblate-ssh server (OCA#233) * [REF] broken_deprecated: Use correct version format - After merge OCA/pylint-odoo#155 we had this unexpected wrong format version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
$to the end of default manifest version format to disallow versions like10.0.1.0.0WHATEVER.Related: #152