Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] test: Add tox for multi-environment and add compatiblity with latest version #21

Merged

Conversation

luiseevaquer
Copy link

@luiseevaquer luiseevaquer commented Apr 16, 2016

No description provided.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 0892acc on vauxoo-dev:master-oca-update-pylint-astroid-dev-lescobarvx into 8bfeace on OCA:master.

@luiseevaquer
Copy link
Author

@moylop260 @pedrobaeza @max3903
Your feedback please

@@ -30,13 +36,15 @@ install:
- pip install --upgrade pyopenssl ndg-httpsclient pyasn1
- pip install coveralls flake8

# Install tox
- pip install tox
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need this?

Copy link
Collaborator

@moylop260 moylop260 Apr 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you run locally:

cd pylint-odoo
tox

You will be tested 2 virtual environments of pylint-odoo

  • pylint1.4
  • pylint2.0

tox is the most used library in python for multi-environment cases.

@moylop260 moylop260 force-pushed the master-oca-update-pylint-astroid-dev-lescobarvx branch from 0892acc to db782f5 Compare May 9, 2016 05:19
@moylop260 moylop260 changed the title [IMP] Update pylint==2.0.0 and astroid==1.5.0 [IMP] test: Add tox for multi-environment and add compatiblity with latest version May 9, 2016
@moylop260
Copy link
Collaborator

Rebased.

This PR add compatibility with new versions of pylint and astroid.
We are using in requirements.txt the current stable version, but developing for old and new version with small changes.

@coveralls
Copy link

coveralls commented May 9, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling db782f5 on vauxoo-dev:master-oca-update-pylint-astroid-dev-lescobarvx into 6d244c6 on OCA:master.

@dreispt
Copy link
Sponsor Member

dreispt commented May 9, 2016

LGTM 👍

@moylop260
Copy link
Collaborator

@nhomar @pedrobaeza your feedback is welcome!

@moylop260
Copy link
Collaborator

👍

@nhomar nhomar merged commit 7e99c91 into OCA:master May 11, 2016
@luisg123v luisg123v deleted the master-oca-update-pylint-astroid-dev-lescobarvx branch August 6, 2020 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants