[IMP] Add pylint check missing newline in extra extension files. #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@moylop260 @pedrobaeza @max3903 |
|
I see correct this trailing line (it helps in the diff if you add a new line at the end). Even more, in .po files, Odoo or Poedit adds at least 2 trailing lines at the end. |
luiseevaquer
force-pushed
the
master-oca-traling-newlines-otherfiles-dev-lescobarvx
branch
from
b2861b0
to
872e7bb
Compare
|
@lescobarvx We need change this check for cases where don't exists a newline at final file. |
|
@lescobarvx |
luiseevaquer
force-pushed
the
master-oca-traling-newlines-otherfiles-dev-lescobarvx
branch
from
872e7bb
to
df28ec3
Compare
| if os.stat(ext_file).st_size > 0: | ||
| fp.seek(-2, os.SEEK_END) | ||
| last_line = fp.readline() | ||
| if last_line[-1:] not in ['\n', '\r']: |
There was a problem hiding this comment.
Use last_line.endswith('\n') or last_line.endswith('\r')
luiseevaquer
force-pushed
the
master-oca-traling-newlines-otherfiles-dev-lescobarvx
branch
from
df28ec3
to
7c45287
Compare
luiseevaquer
force-pushed
the
master-oca-traling-newlines-otherfiles-dev-lescobarvx
branch
from
7c45287
to
11f9cfe
Compare
luiseevaquer
changed the title
luiseevaquer
force-pushed
the
master-oca-traling-newlines-otherfiles-dev-lescobarvx
branch
2 times, most recently
from
4171029
to
47c25e8
Compare
|
👍 |
moylop260
force-pushed
the
master-oca-traling-newlines-otherfiles-dev-lescobarvx
branch
from
47c25e8
to
c49705e
Compare
|
Rebased |
|
👍 |
|
Please rebase |
moylop260
force-pushed
the
master-oca-traling-newlines-otherfiles-dev-lescobarvx
branch
from
c49705e
to
0af845b
Compare
|
rebased |
|
👍 |
|
Thanks @pedrobaeza |
luisg123v
deleted the
master-oca-traling-newlines-otherfiles-dev-lescobarvx
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[IMP] Add pylint check trailing newlines in other extension files.