Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] test: better way to identify check error expected #26

Merged
merged 1 commit into from
May 8, 2016

Conversation

moylop260
Copy link
Collaborator

Change the test fail summary of

======================================================================
FAIL: test_30_disabling_errors (main.MainTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/moylop260/odoo/pylint-odoo/pylint_odoo/test/main.py", line 102, in test_30_disabling_errors
    self.assertEqual(sorted(real_errors.items()), sorted(EXPECTED_ERRORS.items()))
AssertionError: Errors found 23 different to expected 22
----------------------------------------------------------------------
Ran 3 tests in 0.699s

to

======================================================================
FAIL: test_30_disabling_errors (main.MainTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/moylop260/odoo/pylint-odoo/pylint_odoo/test/main.py", line 102, in test_30_disabling_errors
    self.assertEqual(sorted(real_errors.items()), sorted(EXPECTED_ERRORS.items()))
AssertionError: Lists differ: [('api-one-deprecated', 4), ('... != [('api-one-deprecated', 4), ('...

First differing element 6:
('javascript-lint', 3)
('javascript-lint', 2)

Second list contains 1 additional elements.
First extra element 32:
('xml-syntax-error', 2)

Diff is 1150 characters long. Set self.maxDiff to None to see it.

----------------------------------------------------------------------
Ran 3 tests in 0.699s

@moylop260 moylop260 self-assigned this Apr 27, 2016
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling c7e73f6 on vauxoo-dev:master-oca-ref-test-moy into 8bfeace on OCA:master.

@luiseevaquer
Copy link

👍

@moylop260
Copy link
Collaborator Author

ping

@moylop260
Copy link
Collaborator Author

@pedrobaeza @max3903
Your feedback is welcome

@pedrobaeza
Copy link
Member

I like more this way!

👍

@dreispt
Copy link
Sponsor Member

dreispt commented May 7, 2016

The MQT badly needs something like this...

@dreispt
Copy link
Sponsor Member

dreispt commented May 7, 2016

Needs a rebase

@moylop260
Copy link
Collaborator Author

Rebased
Please, merge this PR before that other one to fix conflicts in all PRs at end.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling b6452c4 on vauxoo-dev:master-oca-ref-test-moy into 7a10bf4 on OCA:master.

@moylop260
Copy link
Collaborator Author

Can we merge it?

@dreispt dreispt merged commit b1c5895 into OCA:master May 8, 2016
@luisg123v luisg123v deleted the master-oca-ref-test-moy branch August 6, 2020 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants