[REF] requirements: upgrade pylint version #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fernandahf
force-pushed
the
master-upgrade-pylint-version-fer
branch
from
81d8251
to
2388d94
Compare
|
Could you review this, please? Regards. |
moylop260
reviewed
Jan 21, 2021
fernandahf
force-pushed
the
master-upgrade-pylint-version-fer
branch
from
5e64921
to
d42666c
Compare
isort>5 is only compatible with py36 and above, therefore we use a ISortDriver to support both versions and that it's not necessary to pin only one version.
fernandahf
force-pushed
the
master-upgrade-pylint-version-fer
branch
from
d42666c
to
dd470b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
The following line of code:
pylint-odoo/requirements.txt
Line 8 in 1b9018e
is pinning the pylint version because it could raise red with newer versions but we need keep upgrading this version each period of time
There is a new release pylint-2.6.0 on Aug 21, 2020
Current behavior before PR:
pylint-odoo works correctly.
Desired behavior after PR is merged:
pylint-odoo works correctly with new pylint version.
Fix #319
-- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr