Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] attribute-string-redundant: "string" of related field is taken from the referenced one #341

Merged
merged 1 commit into from
Sep 8, 2021

Conversation

moylop260
Copy link
Collaborator

So redefining the string is a valid case.
For instance:

  • parent_date = fields.Date(related="parent_id.date", string="parent date")

If a string is not specified, field will be "Date".
But I need the string to be "Parent Date"

Fix #332

…from the referenced one

So redefining the string is a valid case.
For instance:
 - parent_date = fields.Date(related="parent_id.date", string="parent date")

If a string is not specified, field will be "Date".
But I need the string to be "Parent Date"

Fix OCA#332
@moylop260 moylop260 self-assigned this Sep 7, 2021
@moylop260 moylop260 merged commit 7dc9de0 into OCA:master Sep 8, 2021
@moylop260 moylop260 deleted the oca-str-related-moy branch September 8, 2021 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

attribute-string-redundant: false positive on related fields
1 participant