Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] xml-syntax-error: Fix crash if a xml has syntax errors #343

Merged
merged 1 commit into from
Sep 8, 2021
Merged

[FIX] xml-syntax-error: Fix crash if a xml has syntax errors #343

merged 1 commit into from
Sep 8, 2021

Conversation

moylop260
Copy link
Collaborator

Fix #331

@moylop260 moylop260 mentioned this pull request Sep 8, 2021
Closed
@moylop260
Copy link
Collaborator Author

After this fix running the following command:

  • pylint -d all -e odoolint --load-plugins=pylint_odoo /tmp/rma/crm_claim_ext/ |grep crm_claim_ext_view.xml

For https://github.com/OCA/rma/blob/d8d1bdbd9c09c74f9cd1ad12e13db884712cc9f3/crm_claim_ext module

The result is:

  • rma/crm_claim_ext/crm_claim_ext_view.xml:1:0: E7902: error: Opening and ending tag mismatch: page line 30 and field, line 33, column 21 (crm_claim_ext_view.xml, line 33) (xml-syntax-error)

instead of crash

@moylop260 moylop260 force-pushed the oca-xml-syntax-error-moy branch 2 times, most recently from 6a23b05 to bb2c539 Compare September 8, 2021 05:13
@moylop260 moylop260 merged commit 7d727a9 into OCA:master Sep 8, 2021
@moylop260 moylop260 deleted the oca-xml-syntax-error-moy branch September 8, 2021 05:21
@antonag32 antonag32 mentioned this pull request Oct 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pylint crashes when object is str
1 participant
@moylop260