[FIX] sql-injection: Fix false positives #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moylop260
force-pushed
the
oca-fix-sql-inj-moy
branch
from
42e0d95
to
867a22f
Compare
Ignore cases when you are using almost one parameter It means you maybe are using a concatenation for valid concatenation but parameters for other cases Ignore cases for private parameters and private methods too It is a common way to use a valid "cr.execute" for Odoo views in newer versions Fix OCA#334
moylop260
force-pushed
the
oca-fix-sql-inj-moy
branch
from
867a22f
to
af01790
Compare
moylop260
force-pushed
the
oca-fix-sql-inj-moy
branch
from
3b238db
to
746e47d
Compare
moylop260
force-pushed
the
oca-fix-sql-inj-moy
branch
from
746e47d
to
121608f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore cases when you are using almost one parameter
It means you maybe are using a concatenation for valid concatenation but parameters for other cases
Ignore cases for private parameters and private methods too
It is a common way to use a valid "cr.execute" for Odoo views in newer
versions
Fix #334
It could depends of feedback from: