[FIX] duplicate-xml-fields: Support security xml style #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lescobarvx Could you give me your feedback? |
moylop260
force-pushed
the
master-vx-fix-duplicated-xml
branch
from
6c418ac
to
cd9bc7a
Compare
|
ping |
|
👍 |
1 similar comment
|
👍 |
|
@pedrobaeza |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old sentence
field.values()[0]returns the first item fromfield xmlsentence in most cases it works well.But if we have a style different like as
<field eval="1" name="perm_read"/>we should process the second one.Then I change to
field.attrib.get('name')sentence to avoid future problem with styles.Detected from: https://travis-ci.org/OCA/server-tools/jobs/132336867#L423