Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] javascript-lint: Use eslint instead of jshint #97

Merged
merged 6 commits into from
Jan 26, 2017

Conversation

moylop260
Copy link
Collaborator

@moylop260 moylop260 commented Dec 23, 2016

http://eslint.org/ is a tool better than jshint.
Good post about:

FYI this tool requires a upgrade of nodejs version 6 installing for travis with: nvm install 6
This step spent +2 minutes to current time of the lint build.

For merger

Recovered from #87

@moylop260 moylop260 self-assigned this Dec 23, 2016
@moylop260
Copy link
Collaborator Author

ping

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I understand that we need to add a .jslintrc file in MQT, isn't it?

@moylop260
Copy link
Collaborator Author

Yes, that is right
And install nvm too
More info: https://github.com/OCA/maintainer-quality-tools/pull/389/files

@oscarolar
Copy link

👍

Copy link
Member

@yvaucher yvaucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking into account my request.

What is required to ignore the doc folder then ?
Is there a config file to add ?

I'm a bit concerned about the +2 min on each builds, this seems a lot to me.

@moylop260
Copy link
Collaborator Author

moylop260 commented Jan 3, 2017

@yvaucher
Thanks for your approve although your questions.

What is required to ignore the doc folder then ?

Generally the doc folder has js files based on templates that we don't want fix lints.
But if you have a good case for re-enable we don't have problem.
(Sorry I didn't understand the question...)

I'll create the change to ignore them.

Is there a config file to add ?

Yes, .jslintrc

I'm a bit concerned about the +2 min on each builds, this seems a lot to me.

Yes me too, but this is a issue of self-travis that have a too old version nodejs installed by default and eslint requires newest 6.latest version
Maybe we can create a new issue for travis-ci in order to request a update of nodejs for the default image used or we could use a way to cache it but I don't have idea how to do it.
The ideas are welcome.

@moylop260
Copy link
Collaborator Author

@yvaucher
Added doc and template directory names to skipping list.

@dreispt dreispt mentioned this pull request Jan 16, 2017
53 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants