[ADD] renamed-field-parameter: detect deprecated field values (digits_compute, select) (#91) #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_compute, select) (Vauxoo#91)
lasley
approved these changes
Dec 27, 2016
| @@ -324,6 +369,15 @@ def visit_call(self, node): | |||
| '_' + argument.arg + '_'): | |||
| self.add_message('method-' + argument.arg, | |||
| node=argument_aux) | |||
| elif (argument.arg in | |||
| self.config.deprecated_field_parameters): | |||
There was a problem hiding this comment.
Non blocking, but you could remove a few lines by using an intermediary variable:
deprecated = self.config.deprecated_field_parameters
| >>> self.colon_list_to_dict(['colon:list', 'empty_key:']) | ||
| {'colon': 'list', 'empty_key': ''} | ||
| """ | ||
| return dict([item.split(":") for item in colon_list]) |
There was a problem hiding this comment.
No need to create a list:
>>> dict(item.split(':') for item in colon_list)
{'key2': 'val2', 'key1': 'val1'}
|
Thanks for the comments @lasley. Updated code as suggested. |
moylop260
approved these changes
Dec 29, 2016
|
@JesusZapata |
|
@moylop260 |
moylop260
deleted the
master-merge-check-renamed-fields-vauxoo-tomeyro
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add check to detect deprecated/renamed parameters in a field constructor.
Checking the parameters specified in: https://github.com/odoo/odoo/blob/10.0/odoo/fields.py#L29