Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] queue_job: Add cancelled state to queue.job #347

Merged
merged 2 commits into from
Sep 3, 2021
Merged

[IMP] queue_job: Add cancelled state to queue.job #347

merged 2 commits into from
Sep 3, 2021

Conversation

hbrunn
Copy link
Member

@hbrunn hbrunn commented May 14, 2021 •
edited
Loading

I'll add tests when we agree this is how it should work

@hbrunn hbrunn mentioned this pull request May 14, 2021
Closed
guewen
guewen reviewed May 18, 2021
View reviewed changes
queue_job/job.py Outdated Show resolved Hide resolved
@guewen
Copy link
Member

guewen commented May 18, 2021

I'll add tests when we agree this is how it should work

It looks good to me :)

@hbrunn hbrunn force-pushed the 12.0-queue_job-cancelled_state branch from 0279dd3 to 32dea7b Compare May 21, 2021 04:18
@hbrunn
Copy link
Member Author

hbrunn commented May 21, 2021

thanks all, changed according to comments

@StefanRijnhart
Copy link
Member

Were you still going to add a test?

@hbrunn hbrunn force-pushed the 12.0-queue_job-cancelled_state branch from 47ff477 to 5045d6d Compare May 21, 2021 17:42
@hbrunn
Copy link
Member Author

hbrunn commented May 21, 2021

now with the promised tests. Anybody have permissions to fix runbot?

StefanRijnhart
StefanRijnhart approved these changes May 22, 2021
View reviewed changes
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

guewen
guewen approved these changes May 22, 2021
View reviewed changes
Copy link
Member

@guewen guewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
About runbot, I don't.

@hbrunn hbrunn mentioned this pull request Jun 11, 2021
Closed
@dreispt
Copy link
Sponsor Member

dreispt commented Jul 29, 2021

@hbrunn Can you please resolve the conflicts? Thanks!

@hbrunn hbrunn force-pushed the 12.0-queue_job-cancelled_state branch from 5045d6d to 6299faa Compare July 29, 2021 16:51
@hbrunn
Copy link
Member Author

hbrunn commented Jul 29, 2021

@dreispt thanks for the heads up!

@hbrunn hbrunn force-pushed the 12.0-queue_job-cancelled_state branch from 6a7db7d to 9720915 Compare July 30, 2021 00:37
@guewen
Copy link
Member

guewen commented Sep 3, 2021

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 12.0-ocabot-merge-pr-347-by-guewen-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit bcdebba into OCA:12.0 Sep 3, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at fab0256. Thanks a lot for contributing to OCA. ❤️

@dzungtran89 dzungtran89 mentioned this pull request Dec 14, 2021
Merged
@sbidoul sbidoul mentioned this pull request May 1, 2023
Open
@sbidoul sbidoul added this to the 12.0 milestone May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simahawk simahawk simahawk left review comments

@guewen guewen guewen approved these changes

@StefanRijnhart StefanRijnhart StefanRijnhart approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
12.0
Development

Successfully merging this pull request may close these issues.
7 participants
@hbrunn @guewen @StefanRijnhart @dreispt @OCA-git-bot @simahawk @sbidoul