Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][FW] queue_job: multiple ports from 14.0 #630

Merged
merged 6 commits into from
Mar 27, 2024
Merged

[15.0][FW] queue_job: multiple ports from 14.0 #630

merged 6 commits into from
Mar 27, 2024

Conversation

sebalix
Copy link
Contributor

@sebalix sebalix commented Mar 6, 2024 •
edited

@OCA-git-bot
Copy link
Contributor

Hi @guewen,
some modules you are maintaining are being modified, check this out!

@sebalix sebalix force-pushed the oca-port-from-14.0-to-15.0-pr-594-629 branch from 58f3759 to bbcd18c Compare March 6, 2024 12:35
@sebalix sebalix marked this pull request as ready for review March 6, 2024 12:38
@sebalix sebalix force-pushed the oca-port-from-14.0-to-15.0-pr-594-629 branch from bbcd18c to 5fc06d6 Compare March 6, 2024 12:44
@sebalix sebalix mentioned this pull request Mar 6, 2024
Merged
guewen
guewen approved these changes Mar 6, 2024
View reviewed changes
Copy link
Member

@guewen guewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@StefanRijnhart StefanRijnhart self-requested a review March 7, 2024 12:48
@sebalix sebalix force-pushed the oca-port-from-14.0-to-15.0-pr-594-629 branch from 6807eab to 5d0a00a Compare March 7, 2024 15:10
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@simahawk
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-630-by-simahawk-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 27, 2024
@OCA-git-bot
Merge PR #630 into 15.0
af807ab 
Signed-off-by simahawk
@OCA-git-bot
Copy link
Contributor

@simahawk your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-630-by-simahawk-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@simahawk
Copy link
Contributor

argh, this is a minor... stopped builds 😁

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-630-by-simahawk-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Mar 27, 2024
@OCA-git-bot
Merge PR #630 into 15.0
74301e0 
Signed-off-by simahawk
@OCA-git-bot
Copy link
Contributor

@simahawk your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-630-by-simahawk-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@simahawk
Copy link
Contributor

no even... I missed the migration step. Ok... Simone... you can do it! 🤣

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-630-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit dac6c6a into OCA:15.0 Mar 27, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 6fa4a48. Thanks a lot for contributing to OCA. ❤️

@StefanRijnhart
Copy link
Member

“Our greatest weakness lies in giving up. The most certain way to succeed is always to try just one more time.”

Thomas Edison

Thank you @simahawk!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guewen guewen guewen approved these changes

@amh-mw amh-mw amh-mw approved these changes

@StefanRijnhart StefanRijnhart StefanRijnhart approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@sebalix @OCA-git-bot @simahawk @StefanRijnhart @guewen @amh-mw @hparfr