[16.0][IMP] queue_job: run specific hook method after max_retries

[QuocDuong1306]

When a job has been tried for max_retries but still fails, final FailedJobError is raised and job is set to Failed.

This PR enables developers to run a specific hook method when this happens.

[OCA-git-bot]

Hi @guewen,
some modules you are maintaining are being modified, check this out!

[amh-mw]

I am generally not a fan of interpolating method names. Pass on_exception as an additional argument to delayable/with_delay instead?

Perhaps the scope could be slightly broader as well? Give the developer a chance to handle all types of exception, not just FailedJobError?

[nilshamerlinck]

• interpolating method names is quite a common pattern in odoo code: see lots of getattr in the codebase :)
• quite elegant imho to be able to define method_name and method_name_on_max_retries_reached nearby, but of course it's a bit subjective
• regarding your last point, that's an interesting idea but it feels quite natural to handle exceptions in the job code itself, e.g. in the EDI framework here

[simahawk]

A more declarative approach could be to use a decorator but it will likely add complexity.
@QuocDuong1306 could you please update the docs?

[QuocDuong1306]

Hi @simahawk , I updated the docs

[oerp-odoo]

I would say whenever job reaches failed state, it would be useful to have a hook, to do something, not when it just failed after max retries, but failed for any reason?

For example, issue described here: #618

[simahawk]

That's a good point. Yet, I think you can subscribe to that particular event easily (job switching to failed).
In fact we could subscribe even in this case and check the max retry counter.
@guewen did you have something in mind regarding handling failures?