Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD] report_qr #288

Merged
merged 2 commits into from
Oct 1, 2019
Merged

[ADD] report_qr #288

merged 2 commits into from
Oct 1, 2019

Conversation

etobella
Copy link
Member

This PR replaces OCA/web#1229

@etobella etobella mentioned this pull request May 13, 2019
Closed
@etobella
Copy link
Member Author

ping @hveficent @jbeficent

@etobella etobella mentioned this pull request Jun 6, 2019
Merged
@pedrobaeza pedrobaeza added this to the 11.0 milestone Jun 17, 2019
jarroyomorales
jarroyomorales approved these changes Jun 27, 2019
View reviewed changes
Copy link

@jarroyomorales jarroyomorales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Increase coverage if possible

@etobella
Copy link
Member Author

etobella commented Aug 2, 2019

@jarroyomorales Added some tests

@HviorForgeFlow
Copy link
Member

test name seems no to be related with tested functionality in test. Maybe some description would be fine

@etobella
Copy link
Member Author

etobella commented Aug 2, 2019

@hveficent splitted into two tests with better names (I hope 😉 )

@HviorForgeFlow
Copy link
Member

Much better

@etobella
Copy link
Member Author

etobella commented Aug 2, 2019

@jbeficent This PR was approved by you in another PR, It is still right for you?

@jarroyomorales
Copy link

Already green 🍏, @jbeficent Can you review?

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rafaelbn
Copy link
Member

@OCA/reporting-engine-maintainers this PR is waiting a PSC 😄

@chienandalu chienandalu mentioned this pull request Sep 19, 2019
Merged
@etobella
Copy link
Member Author

@chienandalu I cherry picked your commit

@pedrobaeza
Copy link
Member

/ocabot merge

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 11.0-ocabot-merge-pr-288-by-pedrobaeza-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Sep 30, 2019
@OCA-git-bot
Merge PR #288 into 11.0
57ce6e2 
Signed-off-by pedrobaeza
@OCA-git-bot OCA-git-bot merged commit 4496a7e into OCA:11.0 Oct 1, 2019
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 8cea303. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chienandalu chienandalu chienandalu left review comments

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@rafaelbn rafaelbn rafaelbn approved these changes

@HviorForgeFlow HviorForgeFlow HviorForgeFlow approved these changes

@jarroyomorales jarroyomorales jarroyomorales approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
11.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@etobella @HviorForgeFlow @jarroyomorales @OCA-git-bot @rafaelbn @pedrobaeza @chienandalu