-
-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[11.0][ADD] document quick access #72
Conversation
The travis will go red due to base_optional_quick_create. It creates a test model that gives problems to this modules. In order to fix it, we can set |
820fe95
to
e482f60
Compare
document_quick_access/README.rst
Outdated
Usage | ||
===== | ||
|
||
# Click on the QR button on the menu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if this can't be added as a general listener in whole web client for not needing to click in any place. Would it be an improvement? If not, I suppose this button is very accessible from any place. Isn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be interesting, but this could blocked by the standard barcode reader of odoo.
Maybe, we could add a shortcut? Right now, there is a button on the menu accessible everywhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, put it on the roadmap the other option and specify here in the README where the button is in the interface (upper right in the navbar
for example).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK! Added the roadmap and regenerated the readme.
I have been reviewing this, and the shortcut is easier to add if we use web_responsive
. Harder with the standard odoo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a shortcut Alt + Shift + Q
a01b814
to
835d389
Compare
835d389
to
077800b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Functional and code review. Works great!
Small comment. In the readme I suggest to explain that by default the barcode should be encoded as "model,id"
model,id is the standard behavior, but this module is ready to accept other formats. We could make an explanation, but that's not the only solution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
As we are talking about QRs on this PR, it is interesting to use OCA/reporting-engine#288, not the standard QR of odoo. Quality is better with this PR. Odoo standard QR has an issue on it that makes it hard to use. |
This PR has the |
This module replaces #56
Now, the name is simpler and it does not generate an extra table with the data.
@pedrobaeza @jbeficent