Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0][ADD] document quick access #72

Merged
merged 1 commit into from
Jun 17, 2019

Conversation

etobella
Copy link
Member

@etobella etobella commented Jun 4, 2019

This module replaces #56
Now, the name is simpler and it does not generate an extra table with the data.

@pedrobaeza @jbeficent

@etobella
Copy link
Member Author

etobella commented Jun 4, 2019

The travis will go red due to base_optional_quick_create. It creates a test model that gives problems to this modules. In order to fix it, we can set @post_install and @at_install.
I made a PR with the change #73

@etobella etobella mentioned this pull request Jun 4, 2019
3 tasks
@etobella etobella force-pushed the 11.0-add-document_quick_access branch 2 times, most recently from 820fe95 to e482f60 Compare June 5, 2019 07:50
@pedrobaeza pedrobaeza added this to the 11.0 milestone Jun 5, 2019
Usage
=====

# Click on the QR button on the menu
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering if this can't be added as a general listener in whole web client for not needing to click in any place. Would it be an improvement? If not, I suppose this button is very accessible from any place. Isn't it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be interesting, but this could blocked by the standard barcode reader of odoo.
Maybe, we could add a shortcut? Right now, there is a button on the menu accessible everywhere.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, put it on the roadmap the other option and specify here in the README where the button is in the interface (upper right in the navbar for example).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK! Added the roadmap and regenerated the readme.
I have been reviewing this, and the shortcut is easier to add if we use web_responsive. Harder with the standard odoo.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a shortcut Alt + Shift + Q

@JordiBForgeFlow JordiBForgeFlow changed the title [ADD] document quick access [11.0][ADD] document quick access Jun 5, 2019
@etobella etobella force-pushed the 11.0-add-document_quick_access branch 3 times, most recently from a01b814 to 835d389 Compare June 5, 2019 11:01
@etobella etobella force-pushed the 11.0-add-document_quick_access branch from 835d389 to 077800b Compare June 5, 2019 16:08
Copy link
Sponsor Member

@JordiBForgeFlow JordiBForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Functional and code review. Works great!

Small comment. In the readme I suggest to explain that by default the barcode should be encoded as "model,id"

@etobella
Copy link
Member Author

etobella commented Jun 5, 2019

model,id is the standard behavior, but this module is ready to accept other formats. We could make an explanation, but that's not the only solution.
The best way to show it is to install printer_zpl2, generate a label for the model with a QR with code object.get_quick_access_code(). In order to show, you could use labellary mode.

Copy link

@jarroyomorales jarroyomorales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@etobella
Copy link
Member Author

etobella commented Jun 6, 2019

As we are talking about QRs on this PR, it is interesting to use OCA/reporting-engine#288, not the standard QR of odoo. Quality is better with this PR. Odoo standard QR has an issue on it that makes it hard to use.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@pedrobaeza pedrobaeza merged commit 9a09a12 into OCA:11.0 Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants