Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][MIG] report_xlsx_helper #361

Merged
merged 28 commits into from Feb 19, 2020
Merged

[13.0][MIG] report_xlsx_helper #361

merged 28 commits into from Feb 19, 2020

Conversation

kongrattapong
Copy link
Contributor

@kongrattapong kongrattapong commented Jan 9, 2020 •
edited

Standard migration.

luc-demeyer and others added 27 commits January 9, 2020 11:23
@luc-demeyer @kongrattapong
rename module
1ecfd41
@luc-demeyer @kongrattapong
xlsx formats
1d218d0
@luc-demeyer @kongrattapong
improved error handling
e01eff0
@luc-demeyer @kongrattapong
autodetect boolean type
41de759
@luc-demeyer @kongrattapong
pylint: disable=old-api7-method-defined
ea13f1b
@luc-demeyer @kongrattapong
pylint: disable=old-api7-method-defined
a4af4b0
@luc-demeyer @kongrattapong
pylint W8112(eval-referenced)
41648f9
@luc-demeyer @kongrattapong
pylint eval-used
f88f69c
@luc-demeyer @kongrattapong
add unit test
03063f4
@oca-travis @kongrattapong
[UPD] Update report_xlsx_helper.pot
2893c69
@luc-demeyer @kongrattapong
[11.0][MIG] report_xlsx_helper: Migration to 11.0
c61600b
@luc-demeyer @kongrattapong
add todo
68e3980
@oca-travis @kongrattapong
[UPD] Update report_xlsx_helper.pot
69c30ef
@OCA-git-bot @kongrattapong
[UPD] README.rst
08aee1f
@luc-demeyer @kongrattapong
[10.0][FIX]fix _render for cell formats
807c018
@luc-demeyer @kongrattapong
[MIG] : Migration to 12.0
44c07b1
@OCA-git-bot @kongrattapong
[UPD] README.rst
549bfd7
@oca-travis @kongrattapong
[UPD] Update report_xlsx_helper.pot
ba21c9f
@OCA-git-bot @kongrattapong
[UPD] README.rst
ef1e459
@luc-demeyer @kongrattapong
date to datetime conversion when autotyping
d0316af
@luc-demeyer @kongrattapong
greenify
5bf77b6
@luc-demeyer @kongrattapong
increase test coverage
662989a
@oca-travis @kongrattapong
[UPD] Update report_xlsx_helper.pot
e0e6ddf
@OCA-git-bot @kongrattapong
report_xlsx_helper 12.0.1.1.0
dff89ba
@ivantodorovich @kongrattapong
FIX error message when cellvalue's type is not recognized
5cdef5c
@OCA-git-bot @kongrattapong
report_xlsx_helper 12.0.1.1.1
c94c36b
@kongrattapong
[IMP] report_xlsx_helper: black, isort
327bb3c
@kongrattapong kongrattapong mentioned this pull request Jan 9, 2020
Closed
4 tasks
@kongrattapong kongrattapong force-pushed the 13.0-mig-xlsx_report_helper branch 2 times, most recently from faadca6 to 7bb075b Compare January 9, 2020 07:01
@kittiu
Copy link
Member

kittiu commented Jan 28, 2020 •
edited

cc @luc-demeyer would you review this :)

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@kittiu kittiu mentioned this pull request Jan 30, 2020
Closed
@kongrattapong kongrattapong mentioned this pull request Jan 31, 2020
Merged
4 tasks
@kongrattapong kongrattapong mentioned this pull request Feb 9, 2020
Open
@Saran440
Copy link
Member

@kongrattapong please cherry-pick this PR #364

@luc-demeyer
Copy link
Contributor

code review & testing ok.
I think we can go ahead and merge this PR.

pankk
pankk approved these changes Feb 13, 2020
View reviewed changes
Copy link
Member

@pankk pankk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review: virtually no changes to the module other than formatting.

@kittiu
Copy link
Member

kittiu commented Feb 15, 2020

@kongrattapong would you change title from xlsx_report_helper -> report_xlsx_helper
Otherwise, other people may repeat this work if he/she can't find this.

@kittiu kittiu mentioned this pull request Feb 15, 2020
Closed
@kongrattapong kongrattapong changed the title [13.0][MIG] xlsx_report_helper [13.0][MIG] report_xlsx_helper Feb 15, 2020
@luc-demeyer
Copy link
Contributor

can someone of the committers merge this one please ?

@luc-demeyer
Copy link
Contributor

@lmignon can you merge ?

@lmignon
Copy link
Sponsor Contributor

lmignon commented Feb 19, 2020

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-361-by-lmignon-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 19, 2020
@OCA-git-bot
Merge PR #361 into 13.0
83f3c45 
Signed-off-by lmignon
@OCA-git-bot
Copy link
Contributor

@lmignon your merge command was aborted due to failed check(s), which you can inspect on this commit of 13.0-ocabot-merge-pr-361-by-lmignon-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@lmignon
Copy link
Sponsor Contributor

lmignon commented Feb 19, 2020

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-361-by-lmignon-bump-patch, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 19, 2020
@OCA-git-bot
Merge PR #361 into 13.0
383eda2 
Signed-off-by lmignon
@OCA-git-bot OCA-git-bot merged commit 3e6f349 into OCA:13.0 Feb 19, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 51b287a. Thanks a lot for contributing to OCA. ❤️

@OCA-git-bot
Copy link
Contributor

@lmignon The merge process could not be finalized because an exception was raised: <class 'requests.exceptions.ReadTimeout'>: A connection-level exception occurred: HTTPSConnectionPool(host='api.github.com', port=443): Read timed out. (read timeout=10).

@luc-demeyer
Copy link
Contributor

@lmignon Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kittiu kittiu kittiu approved these changes

@pankk pankk pankk approved these changes

@christdum christdum christdum approved these changes

@luc-demeyer luc-demeyer luc-demeyer approved these changes

@Saran440 Saran440 Saran440 approved these changes

@ps-tubtim ps-tubtim ps-tubtim approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet