[ADD] 8.0 - report_xlsx

[sebalix]

This is a backport of #38 from @adrienpeiffer (migrated with the instructions found here: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-9.0#if-the-module-doesnt-exist-in-the-90-branch).
It fixes #49 and is needed to solve OCA/account-financial-reporting#8

[coveralls]

Coverage increased (+0.07%) to 30.318% when pulling 91bb68b on osiell:8.0-report_xlsx into 364e764 on OCA:8.0.

[sebalix]

Runbot is green, and ready for "review" (it is the same code that the v9 version).

[pedrobaeza]

Change this to 8.0

[sebalix]

Question: where do we get this ID 143? I was looking for that in https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md but didn't find this information.

[pedrobaeza]

It's in https://github.com/OCA/maintainer-tools/blob/master/tools/repos_with_ids.txt. In the original README template you can see the link: https://raw.githubusercontent.com/OCA/maintainer-tools/master/template/module/README.rst

[sebalix]

Thank you, I missed that.

[pedrobaeza]

You can put the icon used in XLSX files for the module, as the report_xls do. And please squash your commits in one, as they are minimal.

[sebalix]

@pedrobaeza you mean the same icon used by report_xls? https://github.com/OCA/reporting-engine/blob/9.0/report_xls/static/description/icon.png

[sebalix]

Done.

[coveralls]

Coverage increased (+0.8%) to 30.318% when pulling fe69f0f on osiell:8.0-report_xlsx into c368bad on OCA:8.0.

[pedrobaeza]

@pedrobaeza you mean the same icon used by report_xls? https://github.com/OCA/reporting-engine/blob/9.0/report_xls/static/description/icon.png

I suppose there's a new one corresponding to last Excel versions that fits with XLSX format, isn't it? Or maybe an special icon not for Excel, but for the mimetype XLSX (like this search: https://www.google.es/search?q=xlsx+icon&safe=off&client=ubuntu&hs=bDY&channel=fs&source=lnms&tbm=isch&sa=X&ved=0ahUKEwjFv-W6qq3MAhViF8AKHQKoBbIQ_AUIBygB&biw=1700&bih=901)

[sebalix]

Yep I already search that kind of icon for the XLSX format some days ago but did'nt find one with a correct license. I will take a look again.

[sebalix]

Well, just passed half an hour to find out an icon compatible with the AGPL license, without any success. For now I just copied the one from report_xls, but even this one I'm not sure if it is really free.

[pedrobaeza]

The icon is not ruled under AGPL. The possible open license to apply is Creative Commons, but in this case, I think we can use it without problems under the fair usage policy: http://libguides.mit.edu/usingimages

[sebalix]

There are several Creative Commons, but all CC icons found have a NC clause.
So I pick one and update the PR? This subject has already been stated before in OCA?

[sebalix]

Okay, this one is a CC with commercial use allowed: http://www.icons101.com/icon/id_67712/setid_2096/Boxed_Metal_by_Martin/xlsx
PR updated with this new icon.

[pedrobaeza]

👍

[pedrobaeza]

Thanks!

[coveralls]

Coverage increased (+0.8%) to 30.318% when pulling a51134b on osiell:8.0-report_xlsx into c368bad on OCA:8.0.

[coveralls]

Coverage increased (+0.8%) to 30.318% when pulling 3c2802f on osiell:8.0-report_xlsx into c368bad on OCA:8.0.

[bealdav]

a complete detail here but why not class PartnerXlsx() here ? However, It must not prevent merge

[bealdav]

👍 thanks a lot

[mourad-ehm]

👍 Code review

[hparfr]

👍