Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0] [MIG] report_qweb_pdf_fixed_column: Migration to 16.0 #906

Closed

Conversation

RodrigoBM
Copy link
Contributor

standar migration

@pedrobaeza
Copy link
Member

AFAIK, this module is not needed in v16.

@RodrigoBM
Copy link
Contributor Author

AFAIK, this module is not needed in v16.

hi @pedrobaeza

In the delivery report, I found an error.

In Runboat v16:

Selección_981

In Runboat, this PR:

Selección_980

It is probable that this PR adds a solution, but the fix is in another place.

@pedrobaeza
Copy link
Member

Uhm, OK, then the problem seems to be the same as previous versions, indeed.

@RodrigoBM
Copy link
Contributor Author

RodrigoBM commented Jul 8, 2024

I have tried without my fix, and I have managed to do it by adding the following changes.

Selección_983

Selección_985

Selección_986

and it looks like this in runboat v16

Selección_987

and change other views that inherit from report_delivery_document and propose the change in odoo

@pedrobaeza
Copy link
Member

Maybe you can propose it to Odoo.

@RodrigoBM
Copy link
Contributor Author

RodrigoBM commented Jul 8, 2024

Maybe you can propose it to Odoo.

i did it @pedrobaeza .

odoo/odoo#172366

@RodrigoBM RodrigoBM closed this Jul 11, 2024
@pedrobaeza
Copy link
Member

Thank you for the being so diligent. I have manually update OCB branch with these changes for not waiting till the midnight automation, and fast-tracking the PRs to have everything properly aligned.

As this patch will arrive on v17, can you please check that any possible OCA module is the same aligned?

@RodrigoBM RodrigoBM deleted the 16.0-mig-report_qweb_pdf_fixed_column branch July 11, 2024 16:03
@RodrigoBM
Copy link
Contributor Author

RodrigoBM commented Jul 11, 2024

Yes, I'll try to do that.

@RodrigoBM
Copy link
Contributor Author

RodrigoBM commented Jul 22, 2024

Hi @pedrobaeza ,

Change in v17 has already been merged.

I have checked the current modules and I haven't seen any of them impacted.

About the modules fixed in V16, there is only one related PR and I have already commented to add the commit to fix the problem.

Best regards

@pedrobaeza
Copy link
Member

Thanks for the follow up!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants