Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crm_rma_stock_location: Migration V9 #87

Merged
merged 10 commits into from
Aug 26, 2016
Merged

crm_rma_stock_location: Migration V9 #87

merged 10 commits into from
Aug 26, 2016

Conversation

cyrilgdn
Copy link

@cyrilgdn cyrilgdn commented May 11, 2016 •
edited
Loading

Depends on #86

@cyrilgdn cyrilgdn mentioned this pull request May 11, 2016
Closed
10 tasks
guewen
guewen reviewed May 11, 2016
View reviewed changes
crm_rma_stock_location/models/product.py
string='RMA Forecasted Quantity'
)

def _rma_product_template_available(self):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer when the compute methods start by _compute. I think you have to add a @api.depends() here.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guewen
What about create a PR to MT with your guidelines?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forget it this guideline exists...
Thanks

https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#field

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add it to pylint-odoo roadmap...

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guewen
FYI OCA/pylint-odoo#33

@guewen
Copy link
Member

guewen commented May 11, 2016

Great, thanks 👍

cyrilgdn
cyrilgdn reviewed May 11, 2016
View reviewed changes
crm_rma_stock_location/__openerp__.py
##############################################################################
# © 2014-2016 Camptocamp SA
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).


{'name': 'RMA Stock Location',
'version': '1.0',
Copy link
Author

@cyrilgdn cyrilgdn May 11, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to change version.

yvaucher
yvaucher reviewed May 11, 2016
View reviewed changes
crm_rma_stock_location/tests/__init__.py
# © 2016 Cyril Gaudin (Camptocamp)
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).

from . import test_rma_stock
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing EOL

@coveralls
Copy link

coveralls commented May 12, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling dff5d17 on cyrilgdn:crm_rma_stock_location into 2f0b2ff on OCA:9.0.

@coveralls
Copy link

coveralls commented May 12, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling bef7826 on cyrilgdn:crm_rma_stock_location into 2f0b2ff on OCA:9.0.

@yvaucher
Copy link
Member

yvaucher commented May 13, 2016 •
edited
Loading

@cyrilgdn A little lint issue: crm_rma_stock_location/tests/__init__.py:6:1: W391 blank line at end of file

@coveralls
Copy link

coveralls commented May 13, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 9350d34 on cyrilgdn:crm_rma_stock_location into 2f0b2ff on OCA:9.0.

yaniaular
yaniaular reviewed May 16, 2016
View reviewed changes
crm_rma_stock_location/__openerp__.py

{'name': 'RMA Stock Location',
'version': '1.0',
'version': '9.0.1.0.0',
'author': "Camptocamp,Odoo Community Association (OCA)",
Copy link
Member

@yaniaular yaniaular May 16, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check the last author from 8.0?. Please

@cyrilgdn cyrilgdn changed the title crm_rma_stock_location: Migration V9 [WIP] crm_rma_stock_location: Migration V9 May 17, 2016
@moylop260 moylop260 mentioned this pull request May 17, 2016
Merged
@cyrilgdn cyrilgdn force-pushed the crm_rma_stock_location branch 2 times, most recently from 2cca386 to a794047 Compare May 19, 2016 10:04
@cyrilgdn cyrilgdn changed the title [WIP] crm_rma_stock_location: Migration V9 crm_rma_stock_location: Migration V9 May 19, 2016
@cyrilgdn
Copy link
Author

@yaniaular @pedrobaeza PR reworked with V8 modifications!

@moylop260
Copy link

Could you help us to fix the new checks?

************* Module crm_rma_stock_location.tests.test_make_picking_from_picking
crm_rma_stock_location/tests/test_make_picking_from_picking.py:120: [W0123(eval-used), TestPickingFromPicking.assert_picking_type] Use of eval
crm_rma_stock_location/tests/test_make_picking_from_picking.py:140: [W0123(eval-used), TestPickingFromPicking.test_03_picking_type_loss] Use of eval

Use safe_eval instead.

@moylop260
Copy link

moylop260 commented May 19, 2016 •
edited
Loading

crm_rma_stock_location/wizards/claim_make_picking_from_picking.py:9:1: F401 '_' imported but unused

https://travis-ci.org/OCA/rma/jobs/131372113#L420

@cyrilgdn cyrilgdn force-pushed the crm_rma_stock_location branch 2 times, most recently from 771bb8e to cb3e87d Compare May 23, 2016 08:02
@cyrilgdn
Copy link
Author

@moylop260 fixed.

@lasley
Copy link

lasley commented Aug 20, 2016

Thanks for the submission @cyrilgdn - would you mind checking out the failing builds please?

Osval Reyes and others added 9 commits August 23, 2016 09:23
[IMP] crm_rma_stock_location: adapt to Odoo v8.0, include view sectio…
53ec041 
…n for product quantities on hand and forecasted, add unittest, add i18n terms
[REF] crm_rma_stock_location: add init_hooks file for post_init_hook,…
f838c41 
… correct typos in readme, change usage for created locations loss and refurbished, rename compute method _rma_product_available -> _rma_template_available and get defined with @api.multi decorator
[REF] crm_rma_stock_location: simplify rma on hand and forecasted qua…
afdb0e6 
…ntities calculation
@oca-transbot
OCA Transbot updated translations from Transifex
e8ec291
@oca-transbot
OCA Transbot updated translations from Transifex
f756622
@oca-transbot
OCA Transbot updated translations from Transifex
4a7f1ca
@oca-transbot
OCA Transbot updated translations from Transifex
af946b0
@oca-transbot
OCA Transbot updated translations from Transifex
2bfad35
@oca-transbot
OCA Transbot updated translations from Transifex
81408fe
@cyrilgdn
Copy link
Author

@lasley Build is fixed and green!

@lasley
Copy link

lasley commented Aug 26, 2016

LGTM thanks @cyrilgdn 👍

@guewen guewen merged commit c5d1f01 into OCA:9.0 Aug 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@cyrilgdn @guewen @coveralls @yvaucher @moylop260 @lasley @pedrobaeza @yaniaular @oca-transbot