-
-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] method-param: Check param method starts with "_param_" #33
[ADD] method-param: Check param method starts with "_param_" #33
Conversation
inspired in @guewen OCA/rma#87 (comment) |
👍 |
👍 |
…thod starts with "_{param}_"
42badef
to
d5d3d0a
Compare
👍 |
Could merge it? |
@dufresnedavid your feedback is welcome here too |
@moylop260 Is travis will fail if you change the code of a module that does not comply with the new rules? |
@moylop260 I agree with @lmignon , travis must not fail for 7.0, 8.0 and 9.0, otherwise, all pull request are likely going to fail. We don't want to rename existing methods only so that pylint is happy. |
These will be activated as beta messages, which means that don't turn into red Travis builds. Anyway, don't get confused with this repository. This will only allow to make these checks. Its scope is to extend pylint functionalities to detect this kind of Odoo specific errors. It will be in MQT (maintainer-quality-tools) repo where we must activate them for being used. |
@pedrobaeza thanks for the explanation. 👍 |
I will care that in OCA/maintainer-quality-tools#330 |
_compute_
,_search_
and_inverse_
respectively