Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] method-param: Check param method starts with "_param_" #33

Merged
merged 2 commits into from
May 18, 2016

Conversation

moylop260
Copy link
Collaborator

@moylop260 moylop260 commented May 17, 2016

@moylop260 moylop260 self-assigned this May 17, 2016
@moylop260 moylop260 changed the title [ADD] method-{param}: Check {param} method starts with "_{param}_" [ADD] method-param: Check param method starts with "_param_" May 17, 2016
@coveralls
Copy link

coveralls commented May 17, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling 42badef on vauxoo-dev:master-oca-compute-moylop260 into 879cd02 on OCA:master.

@moylop260
Copy link
Collaborator Author

inspired in @guewen OCA/rma#87 (comment)

@pedrobaeza
Copy link
Member

👍

@moylop260 moylop260 added this to the 1.3.0 milestone May 17, 2016
@cyrilgdn
Copy link

👍

@moylop260 moylop260 force-pushed the master-oca-compute-moylop260 branch from 42badef to d5d3d0a Compare May 18, 2016 13:38
@luiseevaquer
Copy link

👍

@coveralls
Copy link

coveralls commented May 18, 2016

Coverage Status

Coverage remained the same at 100.0% when pulling d5d3d0a on vauxoo-dev:master-oca-compute-moylop260 into d91b094 on OCA:master.

@moylop260
Copy link
Collaborator Author

Could merge it?

@moylop260
Copy link
Collaborator Author

@dufresnedavid your feedback is welcome here too

@lmignon
Copy link
Sponsor Contributor

lmignon commented May 18, 2016

@moylop260 Is travis will fail if you change the code of a module that does not comply with the new rules?
You must pay attention that if you require to rename an existing method to comply with these new rules, you'll break the API. In this case the new rules can only be applied for Odoo 10 for existing modules.

@ghost
Copy link

ghost commented May 18, 2016

@moylop260 I agree with @lmignon , travis must not fail for 7.0, 8.0 and 9.0, otherwise, all pull request are likely going to fail. We don't want to rename existing methods only so that pylint is happy.

@pedrobaeza
Copy link
Member

pedrobaeza commented May 18, 2016

These will be activated as beta messages, which means that don't turn into red Travis builds.

Anyway, don't get confused with this repository. This will only allow to make these checks. Its scope is to extend pylint functionalities to detect this kind of Odoo specific errors. It will be in MQT (maintainer-quality-tools) repo where we must activate them for being used.

@ghost
Copy link

ghost commented May 18, 2016

@pedrobaeza thanks for the explanation.

👍

@pedrobaeza pedrobaeza merged commit 0cbd023 into OCA:master May 18, 2016
@moylop260 moylop260 deleted the master-oca-compute-moylop260 branch May 18, 2016 18:58
@moylop260
Copy link
Collaborator Author

travis must not fail for 7.0, 8.0 and 9.0

I will care that in OCA/maintainer-quality-tools#330

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants