Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] map runbot's warn result to gitlab's success_with_warnings #164

Closed

Conversation

hbrunn
Copy link
Member

@hbrunn hbrunn commented Jun 21, 2018

@moylop260 so this was my naive approach to implement the warnings. Didn't work, and I was convinced to do something stupid, until I looked this up at the gitlab side:
https://gitlab.com/gitlab-org/gitlab-ce/blob/master/lib/api/commit_statuses.rb#L98

So next step is to check if it's just as simple as adding the warning status there, but my ruby is not really existing. Any pointers are appreciated.

@hbrunn hbrunn added this to the 11.0 milestone Jun 21, 2018
@moylop260
Copy link
Contributor

Did you mean create a new PR to gitlab-ci in order to support this case?

@hbrunn
Copy link
Member Author

hbrunn commented Jun 29, 2018

yes. but first i have to get familiar with ruby in order to provide a meaningful mr there. that's then more a pet project of mine and will stay in 'work in progress' quite a while. or i will propose to make warning succeed with an amendment that there were warnings. that would be great for my workflow with colleagues - what do you think?

@moylop260
Copy link
Contributor

Yes, if the CIs support a middle status like as runbot (yellow result) is a meaningful for us too.

FYI I requested the same for travis-ci:

@hbrunn
Copy link
Member Author

hbrunn commented Jul 2, 2018

I fear the gitlab people won't be much more forthcoming... For my own purposes, succeeding with a different name or different description already would suffice, how about just doing this instead?

@hbrunn
Copy link
Member Author

hbrunn commented Sep 14, 2018

superseded by #180 as I don't think the api will be extended any time soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants