Skip to content
This repository has been archived by the owner on Sep 16, 2024. It is now read-only.

[IMP] pass builds with warnings as success to gitlab #180

Merged
merged 1 commit into from
Oct 11, 2018

Conversation

hbrunn
Copy link
Member

@hbrunn hbrunn commented Sep 14, 2018

let's show builds with warnings as success but add a comment that there's a warning

@moylop260
Copy link
Contributor

Should be this one a github behavior too?

Is not this change hidding warnings, since that the people don’t open the CI to check the final result?
currently, travis has warnings for this reason.

But lets to hear other opinions

@pedrobaeza @gurneyalex @rvalyi

@pedrobaeza
Copy link
Member

I prefer to have any kind of highlighting. Runbot warnings are important (it's not the same as pylint ones).

@hbrunn
Copy link
Member Author

hbrunn commented Sep 17, 2018

of course warnings are important, and as soon as we can show them in gitlab somehow, let's please do that. This is a temporary proposal until the API allows something like #164

@pedrobaeza
Copy link
Member

OK, as you think it's the best. We are not using runbot anymore with our doodba-qa (https://github.com/Tecnativa/doodba-qa) + Gitlab CI solution.

@hbrunn
Copy link
Member Author

hbrunn commented Sep 18, 2018

I think I'll add this as an option. We'll want to treat warnings as errors often, but there are projects where we're happy to have at least no failures for the time being. And as the project matures, you can turn this on again.

@ap-wtioit
Copy link
Contributor

I support this pull request (we already do similar stuff on our runbot), especially the solution with the context enables the warning to be visible in gitlab as well (we don't have that yet)

@moylop260
Copy link
Contributor

+1 for me as an option.

@hbrunn hbrunn force-pushed the 11.0-runbot_gitlab-warnings branch from 43fdfc2 to f2500f2 Compare October 9, 2018 06:54
@hbrunn
Copy link
Member Author

hbrunn commented Oct 9, 2018

now as an option

@pedrobaeza pedrobaeza merged commit 62a839f into OCA:11.0 Oct 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants