Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] runbot_push_pot #197

Open
wants to merge 1 commit into
base: 11.0
Choose a base branch
from
Open

Conversation

hbrunn
Copy link
Member

@hbrunn hbrunn commented Jan 29, 2020

with this, we can have runbot export pot files for all modules being tested, and push them back to our repository. This way, you can have a completely self hosted gitlab runbot gitlab weblate loop.

@hbrunn hbrunn force-pushed the 11.0-runbot_push_pot branch 2 times, most recently from 87c6c73 to 157a240 Compare January 30, 2020 11:22
Copy link
Contributor

@NL66278 NL66278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@moylop260
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 11.0-ocabot-merge-pr-197-by-moylop260-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jun 12, 2020
Signed-off-by moylop260
@OCA-git-bot
Copy link
Contributor

@moylop260 your merge command was aborted due to failed check(s), which you can inspect on this commit of 11.0-ocabot-merge-pr-197-by-moylop260-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@moylop260
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 11.0-ocabot-merge-pr-197-by-moylop260-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jun 17, 2020
Signed-off-by moylop260
@OCA-git-bot
Copy link
Contributor

@moylop260 your merge command was aborted due to failed check(s), which you can inspect on this commit of 11.0-ocabot-merge-pr-197-by-moylop260-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@hbrunn
Copy link
Member Author

hbrunn commented Jun 19, 2020

failures seem to be caused by this running with python 3.5 instead of 3.7

Comment on lines +71 to +74
subprocess.run(
['git', '-C', checkout, 'diff', 'HEAD', '-U0'],
capture_output=True
).stdout.decode('utf8').split('\n')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about using dual compatibility methods?
I mean,

Suggested change
subprocess.run(
['git', '-C', checkout, 'diff', 'HEAD', '-U0'],
capture_output=True
).stdout.decode('utf8').split('\n')
subprocess.check_output(
['git', '-C', checkout, 'diff', 'HEAD', '-U0'],
).decode('utf8').split('\n')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants