New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] runbot_push_pot #197
base: 11.0
Are you sure you want to change the base?
Conversation
87c6c73
to
157a240
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM
b313d96
to
370a5c6
Compare
/ocabot merge nobump |
On my way to merge this fine PR! |
@moylop260 your merge command was aborted due to failed check(s), which you can inspect on this commit of 11.0-ocabot-merge-pr-197-by-moylop260-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
/ocabot merge nobump |
Hey, thanks for contributing! Proceeding to merge this for you. |
@moylop260 your merge command was aborted due to failed check(s), which you can inspect on this commit of 11.0-ocabot-merge-pr-197-by-moylop260-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
failures seem to be caused by this running with python 3.5 instead of 3.7 |
subprocess.run( | ||
['git', '-C', checkout, 'diff', 'HEAD', '-U0'], | ||
capture_output=True | ||
).stdout.decode('utf8').split('\n') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about using dual compatibility methods?
I mean,
subprocess.run( | |
['git', '-C', checkout, 'diff', 'HEAD', '-U0'], | |
capture_output=True | |
).stdout.decode('utf8').split('\n') | |
subprocess.check_output( | |
['git', '-C', checkout, 'diff', 'HEAD', '-U0'], | |
).decode('utf8').split('\n') |
with this, we can have runbot export pot files for all modules being tested, and push them back to our repository. This way, you can have a completely self hosted gitlab runbot gitlab weblate loop.