Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD][runbot_buildout] improvements #199

Merged

Conversation

hbrunn
Copy link
Member

@hbrunn hbrunn commented May 14, 2020

  • don't have a flag buildout_default on builds, but set a default buildout on the repo. The original was meant to support multiple versions in the same repo, but this turns out awkward and usually you only temporarily have two versions. This you can deal with with branch specific buildout branches then.
  • don't git repack -a, this might drop objects we need later
  • more logging
  • mute sentry for all buildouts

@hbrunn hbrunn force-pushed the 11.0-runbot_buildout-improvments-2020-05-14 branch from 8888a54 to f081cef Compare May 14, 2020 09:23
@hbrunn hbrunn force-pushed the 11.0-runbot_buildout-improvments-2020-05-14 branch 2 times, most recently from 14c5424 to 4015fdd Compare May 14, 2020 11:51
@hbrunn hbrunn force-pushed the 11.0-runbot_buildout-improvments-2020-05-14 branch from 4015fdd to 186cee6 Compare May 14, 2020 12:27
@hbrunn
Copy link
Member Author

hbrunn commented May 14, 2020

I believe the complaints from codepatch are a fluke, it shows at least some file from runbot_docker as the one not being tested enough, and this isn't in the diff here...

after merging this, I think we can rebase #197 and then this should come back green too

@hbrunn hbrunn force-pushed the 11.0-runbot_buildout-improvments-2020-05-14 branch from 186cee6 to 9eb2207 Compare May 14, 2020 12:38
@hbrunn hbrunn force-pushed the 11.0-runbot_buildout-improvments-2020-05-14 branch from 9eb2207 to b3b4513 Compare May 14, 2020 12:42
Copy link
Contributor

@NL66278 NL66278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇 LGTM

Copy link

@thomaspaulb thomaspaulb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moylop260
Copy link
Contributor

/ocabot minor

@OCA-git-bot
Copy link
Contributor

Hi @moylop260. Your command failed:

Invalid command: minor.

Ocabot commands

  • ocabot merge major|minor|patch|nobump

More information

@moylop260
Copy link
Contributor

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 11.0-ocabot-merge-pr-199-by-moylop260-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request May 14, 2020
Signed-off-by moylop260
@OCA-git-bot
Copy link
Contributor

@moylop260 your merge command was aborted due to failed check(s), which you can inspect on this commit of 11.0-ocabot-merge-pr-199-by-moylop260-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@moylop260
Copy link
Contributor

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 11.0-ocabot-merge-pr-199-by-moylop260-bump-minor, awaiting test results.

OCA-git-bot added a commit that referenced this pull request May 14, 2020
Signed-off-by moylop260
@OCA-git-bot
Copy link
Contributor

@moylop260 your merge command was aborted due to failed check(s), which you can inspect on this commit of 11.0-ocabot-merge-pr-199-by-moylop260-bump-minor.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@moylop260
Copy link
Contributor

it can't be merged by ocabot since that there is a unrelated error then merging manually

@moylop260 moylop260 merged commit b7858d5 into OCA:11.0 May 14, 2020
@hbrunn
Copy link
Member Author

hbrunn commented May 14, 2020

thanks @moylop260

Question: Therp uses the pre-docker branch of runbot in v11 because she never did the step to container stuff. Are you still busy with this in v11, or are you using the v13 runbot and do reviews here as a courtesy (in that case, thank you so much)?

@moylop260
Copy link
Contributor

We are using pre-docker too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants