fix deletion of our modules (courtesy @moylop260) #53
Conversation
|
👍 |
|
This fixed next iissue of empty folder of runbot-addons: 👍 |
|
👍 |
|
Ok, that didn't delete the module at all. Hurm. |
|
Amended. Let's see if that's better. (I was deleting |
| @@ -33,7 +33,7 @@ install: | |||
| - travis_install_nightly | |||
| - git clone --depth=1 https://github.com/odoo/odoo-extra ~/odoo-extra | |||
| # odoo-extra has a bunch of v9 modules which aren't compatible, remove them | |||
| - rm -rf $(ls | grep -v runbot$) | |||
| - (cd ~/odoo-extra; rm -rf $(ls | grep -v runbot$)) | |||
There was a problem hiding this comment.
Are those outer parenthesis necessary?
There was a problem hiding this comment.
they make a subshell, so there is no need to cd .. afterwards.
|
This has revealed that |
|
OK, merging. About parenthesis, I think it's not very important if they're redundant because the expression is still very readable |
fix deletion of our modules (courtesy @moylop260)
|
@lepistone janitor is not used by anyone, it would be safe to remove it |
|
@bwrsandman #54 then. Thanks |
…send-dev-lescobarvx [FIX] runbot_send_email: better wording for message sent
No description provided.