Skip to content
This repository has been archived by the owner on Sep 16, 2024. It is now read-only.

remove runbot_janitor because tests fail #54

Merged
merged 1 commit into from
Aug 20, 2015

Conversation

lepistone
Copy link
Member

If someone wants to adopt it and fix the tests, feel free of course.
Thanks!

If someone wants to adopt it and fix the tests, feel free of course.
Thanks!
@pedrobaeza
Copy link
Member

It's still failing...

@nhomar
Copy link
Member

nhomar commented Aug 20, 2015

will we drop modules instead fix them? there is a deeper explanation that the test fail? I feel we should finish it, and only mark it as installable false to avoid lose history.

@bwrsandman
Copy link

I wrote this module for my own purposes. It never did what it was supposed to do and its function has changed. It never worked and has been abandoned. It also provides no real function that runbot doesn't do on its own.

@lepistone is removing it at my request.

@bwrsandman
Copy link

👍

@nhomar
Copy link
Member

nhomar commented Aug 20, 2015

@lepistone @bwrsandman Ok excellent, 👍 in that case.!

@moylop260
Copy link
Contributor

👍

@moylop260
Copy link
Contributor

FYI the original runbot have the error of

AccessError: ('AccessError', u'Sorry, you are not allowed to access this document. Only users with the following access level are currently allowed to do that:\n- Runbot/User\n\t- Runbot/Manager\n\n(Document model: runbot.repo)')

Then this PR can be merged

moylop260 added a commit that referenced this pull request Aug 20, 2015
remove runbot_janitor because tests fail
@moylop260 moylop260 merged commit 9418b56 into OCA:8.0 Aug 20, 2015
@lepistone lepistone deleted the remove-runbot-janitor branch August 21, 2015 11:28
@lepistone
Copy link
Member Author

Thanks @moylop260. I see we still we have this AccessError on a "crawler test" (not a test from runbot-addons). Do you know anything else about it?

@moylop260
Copy link
Contributor

Yeah, runbot module original added groups and security but this create a error in test.
Odoo sa dont have a runbot to check runbot self.

@moylop260
Copy link
Contributor

odoo/odoo-extra#60
Issue reported 3 months ago

@lepistone
Copy link
Member Author

thanks for the info @moylop260

@guewen guewen mentioned this pull request Aug 28, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants