[15.0][MIG] sale_coupon_limit: Migration to 15.0 #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It should be ok now |
We add some compute fields to check the current promotion usage by the limited users. That allows us to refactor the check method a little bit as well unifying the logic. TT30847
Coupons are reset when a sale order is cancelled, but applied programs remain linked to the cancelled order. As they're cancelled, we should not count them in the limits. TT34264
Sometimes Odoo doesn't remove the rules properly until the promotions are refreshed. This could lead to count mismatches. We wan't to ensure the count looking at the lines instead. TT34266
For complying with rules.
Simplify rule and ensure compatibility with sale_coupon_multiple_code_program wich allows to use multiple code programs putting them in the no code promotions many2many field.
Allow coupon_limit settings to be used by other loyalty modules
chienandalu
force-pushed
the
15.0-mig-sale_coupon_limit-2
branch
from
2ef950a
to
da66de1
Compare
|
/ocabot migration sale_coupon_limit |
|
The migration issue (#25) has been updated to reference the current pull request. |
pedrobaeza
approved these changes
Feb 1, 2023
You mean the icon.png? I see it there |
|
Ah, OK, I was just seeing the migration commit. |
victoralmau
approved these changes
Feb 2, 2023
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at c747e46. Thanks a lot for contributing to OCA. ❤️ |
pilarvargas-tecnativa
pushed a commit
to Tecnativa/sale-promotion
that referenced
this pull request
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #96
cc @Tecnativa TT38310
please review @pedrobaeza @victoralmau