[15.0][MIG] sale_coupon_order_line_link: Migration to 15.0 #94
Conversation
Technical module linking order lines with programs TT30850
Filter lines that are related to a reward: either they genereted it or
the reward is applied to them. For example:
- A promotion product domain could be: ("id", "=" product_a.id)
- The same promotion has a reward product B
- On a sale order with products A, B and C:
- A reward line will be generated to discount B's amount and will be
linked to the promotion.
- Line A will have a link to the reward line as it was the condition
for the promotion.
- Line B will also have a link to the reward line as it's the line
over which the discount is made.
TT31755
On the reward lines we can just invert the relation comlumns to have the lines that generated them. TT31755
We can now view which promotions are applied visually. TT35401
Currently translated at 100.0% (15 of 15 strings) Translation: sale-promotion-14.0/sale-promotion-14.0-sale_coupon_order_line_link Translate-URL: https://translation.odoo-community.org/projects/sale-promotion-14-0/sale-promotion-14-0-sale_coupon_order_line_link/it/
If a third module adds an extra discount scope, we should: - Allow integration returning always at least an empty object - Allow compatibility by inheritance hooking into the method that defines the scoped lines. TT36131
In some cases the `recompute_coupon_lines` method could lead to miss the previously created links. We want to ensure those links at the end of such method. TT40205
chienandalu
force-pushed
the
15.0-mig-sale_coupon_order_line_link
branch
from
87658dd
to
46b0303
Compare
|
On my way to merge this fine PR! |
|
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-94-by-pedrobaeza-bump-nobump. After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red. |
|
Wait! Aborting. This must be renamed to |
|
Well, the module depends on |
|
OK, I see... Yes, we can keep the name in this case then. /ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at fef86ac. Thanks a lot for contributing to OCA. ❤️ |
cc @Tecnativa TT37311
please review @victoralmau @CarlosRoca13