Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] sale_coupon_order_suggestion: Migration to 15.0 #109

Merged
merged 3 commits into from
Apr 10, 2023
Merged

[15.0][MIG] sale_coupon_order_suggestion: Migration to 15.0 #109

merged 3 commits into from
Apr 10, 2023

Conversation

chienandalu
Copy link
Member

@chienandalu chienandalu commented Feb 15, 2023 •
edited by pedrobaeza
Loading

I made a tentative to migrate the widget to OWL but it stumbled upon legacy incompatibilities. A convert it into an ESM module anyway.

cc @Tecnativa TT39006

please review @CarlosRoca13 @stefan-tecnativa

@pedrobaeza
Copy link
Member

/ocabot migration sale_coupon_order_suggestion

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Apr 1, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Apr 1, 2023
Open
21 tasks
@pedrobaeza pedrobaeza force-pushed the 15.0-mig-sale_coupon_order_suggestion branch from 562e047 to fff18c2 Compare April 6, 2023 22:33
pedrobaeza
pedrobaeza requested changes Apr 6, 2023
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried on runboat with a multi-product criteria and a multi-gift reward, and I'm not able to get the suggestion icon

@chienandalu chienandalu force-pushed the 15.0-mig-sale_coupon_order_suggestion branch from fff18c2 to 2af43ae Compare April 10, 2023 10:42
@chienandalu
Copy link
Member Author

I just rebased and it seems to work fine with the updated code now

pedrobaeza
pedrobaeza approved these changes Apr 10, 2023
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, tested. If you remove the promotion line, then the icon doesn't appear again, but I think that's something that already happens in previous version. Please check anyway.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-109-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c569921 into OCA:15.0 Apr 10, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 323a45f. Thanks a lot for contributing to OCA. ❤️

pilarvargas-tecnativa pushed a commit to Tecnativa/sale-promotion that referenced this pull request May 30, 2023
@OCA-git-bot
Merge PR OCA#109 into 15.0
112cd40 
Signed-off-by pedrobaeza
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chienandalu @pedrobaeza @OCA-git-bot