Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] sale_coupon_selection_wizard: Migration to 15.0 #107

Merged
merged 3 commits into from
Apr 6, 2023
Merged

[15.0][MIG] sale_coupon_selection_wizard: Migration to 15.0 #107

merged 3 commits into from
Apr 6, 2023

Conversation

chienandalu
Copy link
Member

@chienandalu chienandalu commented Feb 14, 2023 •
edited by pedrobaeza
Loading

@chienandalu chienandalu force-pushed the 15.0-mig-sale_coupon_selection_wizard branch 3 times, most recently from ed3237b to 9445d54 Compare February 14, 2023 10:32
This was referenced Feb 15, 2023
Merged
Merged
@chienandalu chienandalu force-pushed the 15.0-mig-sale_coupon_selection_wizard branch from 9445d54 to 320c1c8 Compare February 17, 2023 10:56
@pilarvargas-tecnativa
Copy link
Contributor

Code and functionality are correct but tests fail

@CarlosRoca13
Copy link
Contributor

Code and functionality are correct but tests fail

That's because the dependencies are not merged yet

@pilarvargas-tecnativa
Copy link
Contributor

Code and functionality are correct but tests fail

That's because the dependencies are not merged yet

I have tested the functionality locally with all available dependencies and the tests fail

@chienandalu chienandalu force-pushed the 15.0-mig-sale_coupon_selection_wizard branch from 320c1c8 to f222197 Compare February 20, 2023 12:01
@pedrobaeza
Copy link
Member

/ocabot migration sale_coupon_selection_wizard

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Apr 1, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Apr 1, 2023
Open
21 tasks
@pedrobaeza pedrobaeza force-pushed the 15.0-mig-sale_coupon_selection_wizard branch from f222197 to 925d173 Compare April 1, 2023 11:31
@pedrobaeza
Copy link
Member

@chienandalu I have rebased now that the dependencies are merged, and it seems there's still some things to change to the new split model.

@pedrobaeza
Copy link
Member

/ocabot migration sale_coupon_selection_wizard

@chienandalu chienandalu force-pushed the 15.0-mig-sale_coupon_selection_wizard branch from 925d173 to dc0d4e4 Compare April 5, 2023 08:39
pedrobaeza
pedrobaeza approved these changes Apr 6, 2023
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on runboat

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-107-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit b3d64e0 into OCA:15.0 Apr 6, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at ea388e3. Thanks a lot for contributing to OCA. ❤️

pilarvargas-tecnativa pushed a commit to Tecnativa/sale-promotion that referenced this pull request May 30, 2023
@OCA-git-bot
Merge PR OCA#107 into 15.0
3fcba0e 
Signed-off-by pedrobaeza
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@CarlosRoca13 CarlosRoca13 CarlosRoca13 approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@chienandalu @pilarvargas-tecnativa @CarlosRoca13 @pedrobaeza @OCA-git-bot