[15.0][MIG] sale_coupon_criteria_multi_product: Migration to version 15.0 #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's a merge commit, so the history is not correct. You should redo it. |
stefan-tecnativa
force-pushed
the
15.0-mig-sale_coupon_criteria_multi_product
branch
3 times, most recently
from
3c97176
to
52aa17f
Compare
chienandalu
suggested changes
Mar 8, 2023
There was a problem hiding this comment.
Thanks @stefan-tecnativa Some comments below:
- Check tests 🔴
- Reference to the original PR we're superseeding here in the PR description
- Fixup this commit:
|
|
||
| * `Domatix <https://www.domatix.com>`_: | ||
|
|
||
| * Álvaro López Oró |
There was a problem hiding this comment.
Let's add @carolina-domatix as contributor
| # Copyright 2021 Tecnativa - David Vidal | ||
| # License AGPL-3.0 or later (https://www.gnu.org/licenses/agpl). | ||
| { | ||
| "name": "Coupons multi product criteria", |
There was a problem hiding this comment.
Suggested change
| "name": "Coupons multi product criteria", | |
| "name": "Coupons multi product criteria in sales", |
There was a problem hiding this comment.
Done, thanks for all the suggestions.
stefan-tecnativa
force-pushed
the
15.0-mig-sale_coupon_criteria_multi_product
branch
from
52aa17f
to
0f943c4
Compare
chienandalu
suggested changes
Mar 8, 2023
stefan-tecnativa
force-pushed
the
15.0-mig-sale_coupon_criteria_multi_product
branch
from
0f943c4
to
b67d0e8
Compare
chienandalu
suggested changes
Mar 8, 2023
stefan-tecnativa
force-pushed
the
15.0-mig-sale_coupon_criteria_multi_product
branch
from
b67d0e8
to
239a650
Compare
chienandalu
suggested changes
Mar 8, 2023
coupon_criteria_multi_product/migrations/13.0.1.0.0/pre-migration.py
Outdated
Show resolved
Hide resolved
stefan-tecnativa
force-pushed
the
15.0-mig-sale_coupon_criteria_multi_product
branch
from
239a650
to
10ef5bd
Compare
chienandalu
suggested changes
Mar 9, 2023
stefan-tecnativa
force-pushed
the
15.0-mig-sale_coupon_criteria_multi_product
branch
from
10ef5bd
to
ed6a4b5
Compare
stefan-tecnativa
force-pushed
the
15.0-mig-sale_coupon_criteria_multi_product
branch
from
ed6a4b5
to
e9c97db
Compare
pedrobaeza
requested changes
Mar 23, 2023
stefan-tecnativa
force-pushed
the
15.0-mig-sale_coupon_criteria_multi_product
branch
from
e9c97db
to
4ac5a18
Compare
|
/ocabot migration sale_coupon_criteria_multi_product |
pedrobaeza
approved these changes
Mar 24, 2023
|
This PR has the |
|
/ocabot merge nobump |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at 183cfe8. Thanks a lot for contributing to OCA. ❤️ |
This was referenced Apr 1, 2023
pilarvargas-tecnativa
pushed a commit
to Tecnativa/sale-promotion
that referenced
this pull request
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @Tecnativa TT39032
This PR superseeds #88
@chienandalu @pedrobaeza please review!