Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0] Migration of sale_comment_template #145

Merged
merged 43 commits into from
Oct 12, 2022
Merged

[15.0] Migration of sale_comment_template #145

merged 43 commits into from
Oct 12, 2022

Conversation

alan196
Copy link
Contributor

@alan196 alan196 commented Apr 26, 2022

Proposed changes

Migration PR for module base_comment_template.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Migration Update

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the necessary documentation

Comments

This PR depends on

OCA/reporting-engine#619
OCA/account-invoice-reporting#218

@alan196 alan196 mentioned this pull request Apr 26, 2022
Closed
16 tasks
@alan196 alan196 force-pushed the 15.0-mig-sale_comment_template branch from 647fee1 to 7aeaad3 Compare April 26, 2022 20:38
@marylla
Copy link
Contributor

marylla commented Jul 25, 2022

@alan196 Hi there, can you please rebase. :)

@alan196 alan196 force-pushed the 15.0-mig-sale_comment_template branch from 7aeaad3 to 9e69397 Compare July 26, 2022 18:29
@alan196
Copy link
Contributor Author

alan196 commented Jul 26, 2022

@marylla rebased 👍

@marylla
Copy link
Contributor

marylla commented Sep 29, 2022

@alan196 Since account_invoice_comment_template (OCA/account-invoice-reporting#218) is now merged the tests should be working now.
I unfortunately don't know how to restart the builds. :(
Do you? Do we need to rebase again?

guewen and others added 24 commits October 3, 2022 12:38
@guewen @alan196
Rename module sale_condition_template to sale_comment_template
992e2a0
@clb-openfire @alan196
Port module sale_comment_template to V10
852b7e4
@SimoRubi @alan196
[MIG] sale_comment_template: Migration to 10.0
b8708c5
@oca-travis @alan196
[UPD] Update sale_comment_template.pot
f75c3ff
@xavierjimenez @alan196
[MIG] sale_comment_template: Migration to 11.0
664ed51
@pedrobaeza @alan196
[FIX] sale_comment_template: Finish migration
e7e607d 
* Fix and simplify tests
* Adapt view
* Fix documentation
@OCA-git-bot @alan196
[UPD] README.rst
202e9a3
@cubells @alan196
[IMP] sale_comment_template: add partner template
0037bf8
@oca-travis @alan196
[UPD] Update sale_comment_template.pot
711994b
@rven @alan196
[MIG] sale_comment_template: Migration to 12.0
818b5f7
@oca-travis @alan196
[UPD] Update sale_comment_template.pot
c28f8fe
@OCA-git-bot @alan196
[ADD] icon.png
93a3843
@cubells @alan196
[IMP] sale_order_comment: move notes at the end of the report
65ffe05
@OCA-git-bot @alan196
[UPD] README.rst
d4e47a0
@oca-transbot @alan196
Update translation files
bd6d178 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-reporting-12.0/sale-reporting-12.0-sale_comment_template
Translate-URL: https://translation.odoo-community.org/projects/sale-reporting-12-0/sale-reporting-12-0-sale_comment_template/
@OCA-git-bot @alan196
[UPD] README.rst
beaec95
@ernestotejeda @alan196
[FIX] sale_comment_template: unknown res.partner attribute
c25e1f6
@OCA-git-bot @alan196
sale_comment_template 12.0.1.0.1
fd40620
@MiquelRForgeFlow @alan196
[IMP] Add formatted comments on sale order lines
5abc485
@oca-travis @alan196
[UPD] Update sale_comment_template.pot
cf9949c
@OCA-git-bot @alan196
[UPD] README.rst
25589f2
@OCA-git-bot @alan196
sale_comment_template 12.0.1.1.0
d10588e
@oca-transbot @alan196
Update translation files
1ff1da1 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-reporting-12.0/sale-reporting-12.0-sale_comment_template
Translate-URL: https://translation.odoo-community.org/projects/sale-reporting-12-0/sale-reporting-12-0-sale_comment_template/
@marylla @alan196
Added translation using Weblate (German)
9164338
Mario Riva and others added 14 commits October 3, 2022 12:38
@alan196
Translated using Weblate (Italian)
276eb71 
Currently translated at 100.0% (13 of 13 strings)

Translation: sale-reporting-12.0/sale-reporting-12.0-sale_comment_template
Translate-URL: https://translation.odoo-community.org/projects/sale-reporting-12-0/sale-reporting-12-0-sale_comment_template/it/
@petrus-v @alan196
[IMP] sale_comment_template: black, isort, prettier
871cd57
@petrus-v @alan196
[MIG] sale_comment_template: Migration to 14.0
8dc4688
@petrus-v @alan196
[CHG]sale_comment_template: dependency account_invoice_comment_templa…
86caa59 
…te rennamed to account_comment_template
@oca-travis @alan196
[UPD] Update sale_comment_template.pot
c599b0a
@OCA-git-bot @alan196
[UPD] README.rst
cdec40a
@OCA-git-bot @alan196
sale_comment_template 14.0.1.0.1
e57008d
@victoralmau @alan196
[IMP] sale_comment_template: Include changes from 13.0
6997af6
@oca-travis @alan196
[UPD] Update sale_comment_template.pot
652686f
@OCA-git-bot @alan196
[UPD] README.rst
79f32a9
@OCA-git-bot @alan196
sale_comment_template 14.0.2.0.0
fa7efc4
@oca-transbot @alan196
Update translation files
8e25a67 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-reporting-14.0/sale-reporting-14.0-sale_comment_template
Translate-URL: https://translation.odoo-community.org/projects/sale-reporting-14-0/sale-reporting-14-0-sale_comment_template/
@alan196
[IMP] sale_comment_template: black, isort, prettier
50ac0ae
@alan196
[MIG] sale_comment_template: Migration to 15.0
fa63a5c
@alan196 alan196 force-pushed the 15.0-mig-sale_comment_template branch from 9e69397 to fa63a5c Compare October 3, 2022 17:38
@oca-clabot
Copy link

Hey @alan196, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: https://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@alan196
Copy link
Contributor Author

alan196 commented Oct 3, 2022

@marylla rebased 👍

@ibraimFer
Copy link

reviewed 👍

1 similar comment
@olveracuenca
Copy link

reviewed 👍

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@pedrobaeza
Copy link
Member

/ocabot migration sale_comment_template

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-145-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Oct 12, 2022
@OCA-git-bot OCA-git-bot merged commit 63d814c into OCA:15.0 Oct 12, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 09411b9. Thanks a lot for contributing to OCA. ❤️

@alan196 alan196 deleted the 15.0-mig-sale_comment_template branch October 14, 2022 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JuanyDForgeflow JuanyDForgeflow JuanyDForgeflow approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.

None yet