Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0] Migration of account_comment_template #218

Merged
merged 13 commits into from
Sep 29, 2022
Merged

[15.0] Migration of account_comment_template #218

merged 13 commits into from
Sep 29, 2022

Conversation

alan196
Copy link

@alan196 alan196 commented Apr 26, 2022

Proposed changes

Migration PR for module account_comment_template.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Migration Update

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the necessary documentation

Comments

This PR depends on OCA/reporting-engine#619

This was referenced Apr 26, 2022
Closed
Merged
Closed
@alan196 alan196 force-pushed the 15.0-mig-account_comment_template branch from 44d5316 to c222b82 Compare April 26, 2022 20:37
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 28, 2022
hailangvn
hailangvn approved these changes Sep 10, 2022
View reviewed changes
Copy link

@hailangvn hailangvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional test ok. Thanks for the work.

@marylla
Copy link
Contributor

marylla commented Sep 16, 2022

@alan196 Could you please rebase your PR? Thanks a lot. :)

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 18, 2022
petrus-v and others added 13 commits September 27, 2022 08:50
@petrus-v @alan196
rename module from account_invoice_comment_template to account_commen…
a0c4b0d 
…t_template
@petrus-v @alan196
fix warn using assertRegex instead deprecated assertRegexpMatches
7038203
@oca-travis @alan196
[UPD] Update account_comment_template.pot
e8df257
@OCA-git-bot @alan196
[UPD] README.rst
12b9e73
@Yvesldff @alan196
Translated using Weblate (French)
d5ffc50 
Currently translated at 100.0% (11 of 11 strings)

Translation: account-invoice-reporting-14.0/account-invoice-reporting-14.0-account_comment_template
Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-14-0/account-invoice-reporting-14-0-account_comment_template/fr/
@Yvesldff @alan196
Translated using Weblate (French (France))
f6a9364 
Currently translated at 100.0% (11 of 11 strings)

Translation: account-invoice-reporting-14.0/account-invoice-reporting-14.0-account_comment_template
Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-14-0/account-invoice-reporting-14-0-account_comment_template/fr_FR/
@victoralmau @alan196
[IMP] account_comment_template: Adapt to 14.0
51df628 
tests
@oca-travis @alan196
[UPD] Update account_comment_template.pot
1752d5b
@OCA-git-bot @alan196
[UPD] README.rst
b61228b
@OCA-git-bot @alan196
account_comment_template 14.0.2.0.0
4e4a505
@oca-transbot @alan196
Update translation files
dcc6baa 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-invoice-reporting-14.0/account-invoice-reporting-14.0-account_comment_template
Translate-URL: https://translation.odoo-community.org/projects/account-invoice-reporting-14-0/account-invoice-reporting-14-0-account_comment_template/
@alan196
[IMP] account_comment_template: black, isort, prettier
4a54cf0
@alan196
[MIG] account_comment_template: Migration to 15.0
a075db1
@alan196 alan196 force-pushed the 15.0-mig-account_comment_template branch from c222b82 to a075db1 Compare September 27, 2022 13:50
@alan196
Copy link
Author

alan196 commented Sep 27, 2022

@marylla sorry I was on holiday. Rebased 👍

marylla
marylla approved these changes Sep 29, 2022
View reviewed changes
Copy link
Contributor

@marylla marylla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a functional review.
I could create and add the prefix and suffix comment to invoices and print it.
It works as expected. 👍

@adrienpeiffer
Copy link

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-218-by-adrienpeiffer-bump-nobump, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit c0829ed into OCA:15.0 Sep 29, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 31247c0. Thanks a lot for contributing to OCA. ❤️

@alan196 alan196 deleted the 15.0-mig-account_comment_template branch October 3, 2022 17:39
@pedrobaeza
Copy link
Member

/ocabot migration account_comment_template

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marylla marylla marylla approved these changes

@hailangvn hailangvn hailangvn approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.