[9.0] product_brand_sale_report: New module #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedrobaeza
requested changes
Apr 3, 2018
product_brand_sale_report/README.rst
Outdated
|
|
||
| Adds product brand to the sale report. | ||
|
|
||
| Usage |
There was a problem hiding this comment.
Add installation section saying that it requires the module product_brand that is on ...OCA/product-attribute.
| 'name': 'Product Brand Sale Report', | ||
| 'version': '9.0.1.0.0', | ||
| 'category': 'Product', | ||
| 'summary': 'Product Brand Sale Report', |
There was a problem hiding this comment.
Don't put summary, as it equals to the name.
| # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html) | ||
|
|
||
| { | ||
| 'name': 'Product Brand Sale Report', |
There was a problem hiding this comment.
Product Brand in Sales analysis
chienandalu
force-pushed
the
9.0-add-product_brand_sale_report
branch
from
25e6872
to
bd83354
Compare
rafaelbn
approved these changes
Apr 10, 2018
There was a problem hiding this comment.
Thanks @chienandalu 👍
Please add a note to indicate that in v10 v11 ... we must integrate this functionality in the main product_brand module as commented because:
- https://github.com/OCA/product-attribute/pull/191/files#r92249387
- https://github.com/OCA/product-attribute/blob/11.0/product_brand/__manifest__.py#L19
Ping @carlosdauden
chienandalu
force-pushed
the
9.0-add-product_brand_sale_report
branch
from
bd83354
to
ef17bea
Compare
|
@rafaelbn done |
carlosdauden
approved these changes
Apr 10, 2018
pedrobaeza
approved these changes
Apr 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Brand Sale Report
Adds product brand to the sale report.
Usage
Go to Sales > Reports and filter or group by brand.
cc @Tecnativa