Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8.0 move sale payment method #172

Merged
merged 55 commits into from
Dec 1, 2015
Merged

Conversation

bguillot
Copy link
Contributor

This PR moves the module sale_payment_method from e-commerce repo.

See OCA/e-commerce#47 for the reason and discussions about that.

guewen and others added 30 commits March 26, 2013 16:27
…he base and sale_quick_payment adds a wizard to pay a sale order
…e it is too long to be displayed in the menus
…atic payments, prevent cancellation of a sale order with automatic payments
…paid, link the payment with the sale order, and improve the payment view
…ale order to the move line and not the move. Indeed when we import a bank statement and we used the module account_bank_statement_one_move we have 1 one with X customer payment. So we have no choice the sale must be linked to the move lines
… recently so it is less likely to make code crash if it is optional
…yment_ids' are move lines. We want to display the moves so we get them from the lines.
guewen and others added 9 commits March 12, 2015 11:20
@rafaelbn
Copy link
Member

Hello, thank you for this work. Could you please check travis? I think we can go on with this move.

@lepistone
Copy link
Member

Hi! I 👍 .

The failure on one of the travis builds seems unrelated and intermittent (I restarted the job). However, this needs a companion PR to remove the module from e-commerce. I'll take care of this. In the meantime can someone please approve this?

@lepistone
Copy link
Member

The build is green. Two minor commits that were done after this PR are missing, but they are just an icon and prefixing the version with 8.0. I will add those in a subsequent PR. I think we can merge this.

Thanks!

@gurneyalex
Copy link
Member

👍

1 similar comment
@mdietrichc2c
Copy link
Contributor

👍

##############################################################################

{'name': 'Sale Payment Method',
'version': '0.2.1',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tafaRU
Copy link
Member

tafaRU commented Dec 1, 2015

My minor remarks can be addressed in another PR as written at #172 (comment)

I merge then.

tafaRU added a commit that referenced this pull request Dec 1, 2015
@tafaRU tafaRU merged commit 9155923 into OCA:8.0 Dec 1, 2015
@IgnacioMelendrez
Copy link

Hi, I am installing WooCommerce in Odoo 8. Now I have the WooCommerce in the application list, but when I install I get I should install me4 get this error (try to install the module 'connector_ecommerce' depending on the module 'sale_payment_method_automatic_workflow'.
The latter module is not available on your system.) I have 'sale_payment_method_automatic_workflow', 'sale_automatic_workflow' and 'sale_payment_method' in the addons but still I get the same error. Can someone please help me. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet