Move sale_automatic_workflow and sale_payment_method to sale-workflow project

[bguillot]

Hello,

I am here to discuss about moving the modules sale_automatic_workflow (and derived) and sale_payment_method (and derived) to the project sale-workflow.

First of all those modules are very linked with other sale-workflow modules, it leads to loop dependencies for travis for instance (modules in e-commerce depends on modules in sale-workflow).
That's why @gurneyalex and @sebastienbeau suggested to move at least sale_payment_method in my PR OCA/sale-workflow#121

Moreover, thoses modules can be used even in a non e-commerce company (you may want to automate the validation of sale_orders or invoices without having an e-commerce shop).

So after discussing with @guewen it appears that maybe sale_automatic_workflow, sale_payment_method and sale_payment_method_automatic_workflow would be better in sale-workflow project (product_links is still relevant in e-commerce).

That makes also sense for the unpported modules : sale_quick_payment, sale_automatic_workflow_exceptions and sale_payment_method_transaction_id (thoses are glues modules).

Before extracting the branches I would like to have your opinions about that and what will be the best procedure to do it (indeed thoses modules are concerned by some PR's).

I can first do it with sale_payment_method (no PR in 7 or 8).

Thanks for your feedbacks

[gurneyalex]

I'm 👍 on this in principle, but let's not rush things. I'll raise attention on the contributors mailing list.

[max3903]

👍

[florian-dacosta]

👍

[bealdav]

👍

[petrus-v]

👍

I wonder if it's possible to let somehow a message to let users know where to find the new repo host

[pedrobaeza]

I also think that e-commerce repository overlaps a lot of others repositories, and more over, e-commerce is only one channel more, not an isolated flow itself, so I prefer to remove this repo and split its contents in the corresponding areas repos.

[nbessi]

I'm 👍 on the concept but I do not want to break any existing setup. One of the role of OCA is to provide some stability. We were angry enought with Odoo coboy release let's try to do better.

[jgrandguillaume]

👍 to move it

[leio]

Sounds good as I use them outside of e-commerce connectors too (for sort of a prepayment workflow), but please handle some of the mentioned unported modules too then, and any of their issues or PRs as good as github allows (I have ongoing PR for porting one of them)

[guewen]

I discussed about that with @bguillot and agree. The modules are not only related to e-commerce and overlap with other repositories, mainly sale-workflow. 👍

[OSguard]

I agree also to remove this repository and move it outside. 👍

[houssine78]

👍

[bguillot]

Thanks for your answers,

It seems that everyone agree with that.

@nbessi I think most of people that use e-commerce modules will also use sale-workflow so it should not be too dangerous for existing deployments.

I will make a PR to move sale_payment_method (because it has no current PR). But what is the process to move the PR's from e-commerce to sale-workflow ?

[nbessi]

@bguillot ok but at least we should have a mail on community mailing list before/when proceeding

[LeartS]

What's the status of this? Now that Odoo has its own e-commerce module I think it's important to "clean" this.

[pedrobaeza]

I can merge as this has enough thumbs up.

[pedrobaeza]

But I don't see PR for the move in sale-workflow. Can you do it?

[LeartS]

@pedrobaeza who are you talking to?

[pedrobaeza]

Well, actually it can be anyone, but I refer to one of the involved in this conversation.

[bguillot]

Hello,

I started to make PRs here :

OCA/sale-workflow#172

OCA/sale-workflow#171

[gurneyalex]

I'm thinking we should probably add a ChangeLog file at the root of the project for modules which get moved from one project to another. At least this will give the people a hint about where to look.

[rafaelbn]

👍 for moving

[lepistone]

So here is a checklist:

• sale_quick_payment
  • 8.0 port sale_quick_payment to v8, change repo sale-workflow#239 remove sale_quick_payment: moved to sale_workflow #86
• sale_payment_method
  • 7.0 7.0 move sale payment method sale-workflow#171
  • 8.0 8.0 move sale payment method sale-workflow#172 [REM][8.0] sale_payment_method moved to OCA/sale-workflow #88 merged!
• sale_automatic_workflow, sale_payment_method_automatic_workflow sale_automatic_workflow_exception sale_payment_method_transaction_id move 4 modules from OCA/e-commerce sale-workflow#240 remove modules moved in sale-workflow#240 #87

And all the open pull requests that involve those modules. I am migrating:

• 8.0 sale quick payment #54
• add autopay option on sale automatic workflow #55
• sale_automatic_workflow: ship only available goods #80

[antespi]

This PR is also needed too #88, because OCA/sale-workflow#172 is already merged

[lepistone]

Thanks @antespi, I updated the list above.

[pedrobaeza]

This has been done, so I close.