[15.0] [MIG] sale_delivery_state #1851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it optional to work with module `delivery` without adding it as a dependency
Co-authored-by: Simone Orsi <simahawk@users.noreply.github.com>
celm1990
force-pushed
the
15.0-mig-sale_delivery_state
branch
from
f3ba9cb
to
99dd27b
Compare
|
somebody can help me review this PR? |
simahawk
requested changes
Jan 12, 2022
celm1990
force-pushed
the
15.0-mig-sale_delivery_state
branch
from
99dd27b
to
1bd0d2c
Compare
simahawk
approved these changes
Jan 13, 2022
|
/ocabot migration sale_delivery_state |
carlosdauden
approved these changes
Jan 13, 2022
| order.delivery_state = "no" | ||
| elif order.force_delivery_state or order._all_qty_delivered(): | ||
| order.delivery_state = "done" | ||
| elif order._partially_delivered(): |
There was a problem hiding this comment.
Checking in the same loop would be more efficient than filtering, getting precision and going through the lines for both the _all_qty_delivered method and the _partially_delivered method, but I suppose it will be because it is necessary to extend these methods in some case ...
This was referenced Jan 13, 2022
|
/ocabot merge nobump |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at 92c235c. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.