Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] sale_automatic_workflow: Migration to 15.0 #1861

Merged
merged 1 commit into from
Jan 25, 2022

Conversation

yankinmax
Copy link
Contributor

@yankinmax yankinmax commented Jan 11, 2022

PR to migrate sale_automatic_workflow to V15.
Was ported from V14 here:

Depends on:

@yankinmax
Copy link
Contributor Author

yankinmax commented Jan 11, 2022

Note:
There is no stock.inventory model anymore in V15.

inventory = self.env["stock.inventory"].create(

@yankinmax yankinmax force-pushed the 15.0-MIG-sale_automatic_workflow branch 3 times, most recently from 076b756 to b6a3f46 Compare January 13, 2022 12:12
@yankinmax
Copy link
Contributor Author

@simahawk can you pls take a look?

Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG. #1851 is getting merged. Pls drop the test req and squash the last commit on the migration one.

@simahawk
Copy link
Contributor

/ocabot migration sale_automatic_workflow

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Jan 13, 2022
@yankinmax yankinmax force-pushed the 15.0-MIG-sale_automatic_workflow branch from b6a3f46 to 307fe35 Compare January 13, 2022 12:54
Copy link
Sponsor Contributor

@celm1990 celm1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add skip_sms to context.
https://github.com/OCA/sale-workflow/blob/14.0/sale_automatic_workflow/models/stock_picking.py#L35

When module stock_sms is installed and sms is enabled, Odoo try show wizard and avoid validate picking(If validate_picking is enable on workflow). see https://github.com/odoo/odoo/blob/15.0/addons/stock_sms/models/stock_picking.py#L14

image

Run Cron job and Picking is not validate, if i try validate manually wizard is show
image

@yankinmax yankinmax force-pushed the 15.0-MIG-sale_automatic_workflow branch from 307fe35 to d9bd3e4 Compare January 17, 2022 08:28
@yankinmax
Copy link
Contributor Author

@simahawk @celm1990 @rousseldenis can we proceed here?

* Module has now dependency on sale_delivery_state
* sale_automatic_workflow_delivery_state is integrated to sale_automatic_workflow
@yankinmax yankinmax force-pushed the 15.0-MIG-sale_automatic_workflow branch from d9bd3e4 to 52e61ea Compare January 20, 2022 12:54
@yankinmax
Copy link
Contributor Author

@simahawk is it ready to be approved?

@simahawk
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-1861-by-simahawk-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit aa6accc into OCA:15.0 Jan 25, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b40a7a0. Thanks a lot for contributing to OCA. ❤️

@johnny-longneck
Copy link
Contributor

I was starting to test the sale_automatic_workflow module.
In my setup it was not creating invoices and automatic tests failed.

Is it not fully migrated, yet?

@yankinmax
Copy link
Contributor Author

@johnny-longneck I wonder if such happens because at the moment of merge everything was ok. Maintainers wouldn't merge non-working migrations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants