-
-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG] sale_automatic_workflow: Migration to 15.0 #1861
[MIG] sale_automatic_workflow: Migration to 15.0 #1861
Conversation
Note:
|
076b756
to
b6a3f46
Compare
@simahawk can you pls take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG. #1851 is getting merged. Pls drop the test req and squash the last commit on the migration one.
/ocabot migration sale_automatic_workflow |
b6a3f46
to
307fe35
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add skip_sms
to context.
https://github.com/OCA/sale-workflow/blob/14.0/sale_automatic_workflow/models/stock_picking.py#L35
When module stock_sms
is installed and sms is enabled, Odoo try show wizard
and avoid validate picking(If validate_picking
is enable on workflow). see https://github.com/odoo/odoo/blob/15.0/addons/stock_sms/models/stock_picking.py#L14
Run Cron job and Picking is not validate, if i try validate manually wizard is show
307fe35
to
d9bd3e4
Compare
@simahawk @celm1990 @rousseldenis can we proceed here? |
* Module has now dependency on sale_delivery_state * sale_automatic_workflow_delivery_state is integrated to sale_automatic_workflow
d9bd3e4
to
52e61ea
Compare
@simahawk is it ready to be approved? |
/ocabot merge nobump |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at b40a7a0. Thanks a lot for contributing to OCA. ❤️ |
I was starting to test the sale_automatic_workflow module. Is it not fully migrated, yet? |
@johnny-longneck I wonder if such happens because at the moment of merge everything was ok. Maintainers wouldn't merge non-working migrations. |
PR to migrate sale_automatic_workflow to V15.
Was ported from V14 here:
Depends on: