Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] sale_order_revision #1931

Closed
wants to merge 33 commits into from
Closed

[15.0][MIG] sale_order_revision #1931

wants to merge 33 commits into from

Conversation

jwaes
Copy link

@jwaes jwaes commented Feb 24, 2022 •
edited

rvalyi and others added 30 commits February 24, 2022 09:56
@rvalyi @jwaes
[ADD] sale_order_revision, modeled after purchase_order_revision OCA …
d7796d4 
…module by Agile Business Group
@gurneyalex @jwaes
[FIX+IMP] sale_order_revision: Several things:
55aaf9f 
* extract description from __openerp__.py
* move things according to standard OCA layout
* reformatting
* port to new API
* Major rewrite of the 7.0 version:

  * the name of the SO is kept, and a revision number is appended
  * old revisions are made inactive
  * rewrite the copy logic

* update translations, added en.po fr.po
* fix typo in README
* use post_init_hook
* more assertions in the test
* sale_order_revision: remove en.po
* current_revision is only visible for non current revisions
@jwaes
Added german po file
71e728e
@sysadminmatmoz @jwaes
Slovene translations added
1178499
@oca-transbot @jwaes
OCA Transbot updated translations from Transifex
1deadde
@JayVora-SerpentCS @jwaes
[MIG] sale_order_revision: Migration to v10
8d677a3
@grindtildeath @jwaes
[FIX] sale_order_revision: 2 things:
94a246e 
* Fix create revision and improve view invisibility
* Fix unrevisioned name and improve test
@gurneyalex @jwaes
[FIX] sale_order_revision: wrong keyword (OCA#554)
f7864bd 
wrong keyword name in SaleOrder.copy definition
was breaking sale order duplication
@oca-travis @jwaes
[UPD] Update sale_order_revision.pot
3c645a1
@devang-dreambits @jwaes
[MIG] sale_order_revision: Migration to 11.0
673e942
@simonitfi @jwaes
Hide Revisions-tab entirely if there is not any revisions
1e077dd
@rven @jwaes
[MIG] sale_order_revision: Migration to 12.0
a42e5fb
@oca-travis @jwaes
[UPD] Update sale_order_revision.pot
b37537d
@oca-transbot @jwaes
Update translation files
7fe7186 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_order_revision
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_order_revision/
@marylla @jwaes
Translated using Weblate (German)
5949d72 
Currently translated at 100.0% (14 of 14 strings)

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_order_revision
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_order_revision/de/
@OCA-git-bot @jwaes
[UPD] README.rst
509fe1f
@liweijie0812 @jwaes
Translated using Weblate (Chinese (Simplified))
b14f804 
Currently translated at 100.0% (14 of 14 strings)

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_order_revision
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_order_revision/zh_CN/
@Roodin @jwaes
Translated using Weblate (Spanish)
8a97a26 
Currently translated at 100.0% (14 of 14 strings)

Translation: sale-workflow-12.0/sale-workflow-12.0-sale_order_revision
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_order_revision/es/
@jwaes
[MIG] sale_order_revision: Migration to 13.0
379694f 
[13.0] fix pre-commit + formatting

add test lines and linting xml
@oca-travis @jwaes
[UPD] Update sale_order_revision.pot
09cfa66
@OCA-git-bot @jwaes
[UPD] README.rst
6755fc5
@oca-transbot @jwaes
Update translation files
c2ab1bb 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-13.0/sale-workflow-13.0-sale_order_revision
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_order_revision/
@kittiu @jwaes
[14.0][MIG] sale_order_revision
c7775fb
@oca-travis @jwaes
[UPD] Update sale_order_revision.pot
cd6ef5a
@OCA-git-bot @jwaes
[UPD] README.rst
389e7e3
@victoralmau @jwaes
[IMP] sale_order_revision: Tests are added to check that the addon wo…
86bb10a 
…rks as expected.

TT33433
@OCA-git-bot @jwaes
sale_order_revision 14.0.1.0.1
0f17e99
@victoralmau @jwaes
[IMP] sale_order_revision: Set state=cancel in _prepare_revision_data…
f170dfd 
…() function.
@oca-travis @jwaes
[UPD] Update sale_order_revision.pot
a474c14
@OCA-git-bot @jwaes
sale_order_revision 14.0.1.1.0
362c8e7
@oca-clabot
Copy link

Hey @jwaes, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@jwaes jwaes mentioned this pull request Feb 24, 2022
Open
@jwaes jwaes mentioned this pull request Apr 1, 2022
Closed
leemannd
leemannd approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@leemannd leemannd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migration ok and module tested. Works like a charm

CRogos
CRogos approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@CRogos CRogos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review LGTM!

@CRogos
Copy link
Contributor

CRogos commented Sep 20, 2022

OCA/server-ux#522 has been accepted. Could you re trigger the build to see if build and tests are ok?

cyrilmanuel
cyrilmanuel approved these changes Nov 11, 2022
View reviewed changes
Copy link

@cyrilmanuel cyrilmanuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jwaes LGTM Could you re trigger the build ?

@simahawk simahawk changed the title 15.0 mig sale order revision [15.0][MIG] sale_order_revision Nov 11, 2022
@simahawk
Copy link
Contributor

/ocabot migration sale_order_revision

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Nov 11, 2022
@simahawk
Copy link
Contributor

@jwaes pls rebase and drop the merge commit, thanks.

simahawk
simahawk requested changes Nov 11, 2022
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting for rebase and green build

@leemannd leemannd mentioned this pull request Nov 23, 2022
Closed
@leemannd
Copy link
Contributor

Hello @simahawk I superseeds the PR in -> #2275

@simahawk
Copy link
Contributor

@leemannd ok but is red too ;)

@simahawk simahawk closed this Nov 23, 2022
@leemannd
Copy link
Contributor

@simahawk Yep, I'll be fixing the test inbetween this week and early next one

@OCA-git-bot OCA-git-bot mentioned this pull request Apr 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simahawk simahawk simahawk requested changes

@CRogos CRogos CRogos approved these changes

@leemannd leemannd leemannd approved these changes

@cyrilmanuel cyrilmanuel cyrilmanuel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.

None yet