Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] base_revision #456

Closed
wants to merge 28 commits into from
Closed

[15.0][MIG] base_revision #456

wants to merge 28 commits into from

Conversation

jwaes
Copy link
Contributor

@jwaes jwaes commented Feb 24, 2022

No description provided.

kittiu and others added 13 commits February 24, 2022 09:17
@kittiu @jwaes
[14.0][ADD] base_revision
ef23650
@kittiu @jwaes
[IMP] improve test, use odoo_test_helper
83e78ec
@oca-travis @jwaes
[UPD] Update base_revision.pot
f8075ed
@OCA-git-bot @jwaes
[UPD] README.rst
de3bdda
@anasuarez1 @jwaes
Added translation using Weblate (Spanish)
ab7e8a9
@anasuarez1 @jwaes
Translated using Weblate (Spanish)
663ee2b 
Currently translated at 92.3% (12 of 13 strings)

Translation: server-ux-14.0/server-ux-14.0-base_revision
Translate-URL: https://translation.odoo-community.org/projects/server-ux-14-0/server-ux-14-0-base_revision/es/
@dreispt @jwaes
[FIX] base_revision: auto_search and no_destroy are no longer valid a…
c1ee68e 
…ttributes
@OCA-git-bot @jwaes
base_revision 14.0.1.0.1
86c909b
@victoralmau @jwaes
[IMP] base_revision: Add revisions_count field + update the state fie…
72f6cf7 
…ld if it exists in the model.
@oca-travis @jwaes
[UPD] Update base_revision.pot
6580240
@OCA-git-bot @jwaes
base_revision 14.0.1.1.0
07b668f
@jwaes
[IMP] base_revision: black, isort, prettier
ea88623
@jwaes
[MIG] base_revision: Migration to 15.0
8195bd9
@oca-clabot
Copy link

Hey @jwaes, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

  • @jwaes (login unknown in OCA database)

Appreciation of efforts,
OCA CLAbot

This was referenced Feb 24, 2022
Open
Closed
@jwaes jwaes changed the title 15.0 mig base revision [15.0][MIG] base_revision Feb 24, 2022
@jwaes
Copy link
Contributor Author

jwaes commented Apr 1, 2022

I don't understand. I just added a few extra test lines and now all 4 checks fail ?

@jwaes
Copy link
Contributor Author

jwaes commented Apr 1, 2022

OCA/sale-workflow#1931
depends on this

@JasminSForgeFlow
Copy link
Contributor

Hi @jwaes,

Can you please squash commits and keep only one for migration code?

Thanks

@jwaes
Copy link
Contributor Author

jwaes commented Apr 4, 2022

Can you please squash commits and keep only one for migration code?

i tried 'something', but not sure it is correct :-(

@ao-landoo
Copy link

@jwaes Could you try to squash the commits correctly so we can move forward?

@koenloodts koenloodts mentioned this pull request Jun 16, 2022
Closed
@leemannd
Copy link

Base work seems legit. I'm currently testing it.
@jwaes all commits after the one doing the migration could be sqashed together. 8195bd9

You'll find here a documentation to help you -> https://www.git-tower.com/learn/git/faq/git-squash

@ao-landoo ao-landoo mentioned this pull request Aug 12, 2022
Merged
@ao-landoo
Copy link

Continues on #522 as no activity

leemannd
leemannd reviewed Aug 15, 2022
View reviewed changes
Copy link

@leemannd leemannd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well, but commits needs reworks

@pedrobaeza pedrobaeza closed this Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leemannd leemannd leemannd left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.