-
-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] sale_update_pricelist: #198
Conversation
class SaleOrder(models.Model): | ||
_inherit = 'sale.order' | ||
|
||
def onchange_pricelist_id(self, cr, uid, ids, pricelist_id, order_lines, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can not you use new api here?
Cool feature, thank @hugosantosred for this job.... I have just some comments about the functionality and algorithm. Another point if that it should copy and paste the original test case for this method and improve with the new behavior in sale module in order to avoid any regresion due to this installtion.. Thanks. Conceptually 👍 until test is added. |
@nhomar Changes done to README.rst. Thanks for the comments! I will make the test cases soon. |
@hugosantosred, there's already a proposed PR that handles exactly the same use case: #54. But it's even more versatile, because it includes a button that allows you to launch the calculation whenever you want, even if there's no change on the pricelist (for example, to handle a change in list prices), so for me this one 👎 |
I close this one as #54 is already merged |
…CA#198) Before this fix the product's packs new sale order line have multiple taxes: one por each company. Actually only need to add the taxes realated to the sale order's company.
Module for change line prices when pricelist changed in sale order.