Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] sale_update_pricelist: #198

Closed
wants to merge 3 commits into from

Conversation

hugosantosred
Copy link
Member

Module for change line prices when pricelist changed in sale order.

class SaleOrder(models.Model):
_inherit = 'sale.order'

def onchange_pricelist_id(self, cr, uid, ids, pricelist_id, order_lines,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can not you use new api here?

@nhomar
Copy link
Member

nhomar commented Aug 21, 2015

Cool feature, thank @hugosantosred for this job.... I have just some comments about the functionality and algorithm.

Another point if that it should copy and paste the original test case for this method and improve with the new behavior in sale module in order to avoid any regresion due to this installtion..

Thanks.

Conceptually 👍 until test is added.

@hugosantosred
Copy link
Member Author

@nhomar Changes done to README.rst. Thanks for the comments!

I will make the test cases soon.

@pedrobaeza
Copy link
Member

@hugosantosred, there's already a proposed PR that handles exactly the same use case: #54. But it's even more versatile, because it includes a button that allows you to launch the calculation whenever you want, even if there's no change on the pricelist (for example, to handle a change in list prices), so for me this one 👎

@pedrobaeza
Copy link
Member

I close this one as #54 is already merged

@pedrobaeza pedrobaeza closed this Sep 7, 2015
ernestotejeda pushed a commit to Tecnativa/sale-workflow that referenced this pull request Aug 22, 2019
…CA#198)

Before this fix the product's packs new sale order line have multiple taxes:
one por each company. Actually only need to add the taxes realated to the
sale order's company.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants