[16.0][IMP]sale_cancel_reason: set reason to false when status is != cancel #2490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliciagaarzo
approved these changes
Apr 20, 2023
|
Good afternoon @pedrobaeza, I saw this change at the last minute that I had missed, what do you think of the improvement? |
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at ec4f8a6. Thanks a lot for contributing to OCA. ❤️ |
|
Thanks @pedrobaeza! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have find the following problem:
When a cancelled order, is moved to draft, it keeps the cancellation reason and this causes that if we group orders by cancellation reasons:
we will get orders that are not cancelled, but were once cancelled.
With that change on action_draft, when we move the order to draft, again, the reason for cancellation will be reset.