[14.0][IMP] sale_default_uom: Option to base the sale_price on sale_uom_id #2583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @AshishHirapara, |
sistecem
force-pushed
the
14.0
branch
4 times, most recently
from
078aad7
to
947bbdf
Compare
|
@sistecem Could you update your PR title and commit message to mention the changed module like |
sistecem
changed the title
rafaelbn
changed the title
|
Hello @sistecem are you going to continue with this PR? Let me know. If no or nor answer we should close it. Thank you! |
|
Thanks @rafaelbn , is that way ok ? |
|
@sistecem LGTM. Could you add a test for this change ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[14.0][IMP] sale_default_uom: Option to base the sale_price on sale_uom_id
The default sale price was based on uom_id
An option to based on sale_uom_id ( when this is set ) is created with a boolean tick box. Making it easier and more accurate on decimals, useful on big quantities and rare uom Factors.